Re: [quicwg/base-drafts] Explicit linkages for ODCID/OCID TP (#3149)

Martin Thomson <notifications@github.com> Thu, 24 October 2019 21:30 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 96E33120099 for <quic-issues@ietfa.amsl.com>; Thu, 24 Oct 2019 14:30:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PfZF9py3fV6o for <quic-issues@ietfa.amsl.com>; Thu, 24 Oct 2019 14:30:30 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A9DE0120025 for <quic-issues@ietf.org>; Thu, 24 Oct 2019 14:30:30 -0700 (PDT)
Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id AFDEE1C0DD5 for <quic-issues@ietf.org>; Thu, 24 Oct 2019 14:30:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571952629; bh=G0wwFCwvx/p9bSQK3VMGsHLV08oKtnnGDgBX1+ApQlI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dmI0Tbu87mHIdWFsOZ0VBoLd5/uir5vYTQ2DxKBFnjlMn/+HZndoCEftUbU3miFb3 0lmyBNzIq+8/v7sbESIY19cI6ZYAbvN5HwzoPkBqlzAiHj3+9Hw8/3FuAye81eQz7X fH0rg+GLayDK8nAY+SBOa7nBcpLe7Buj+8vxOHxw=
Date: Thu, 24 Oct 2019 14:30:29 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZKT6E72KVSPBF2XEF3X5FHLEVBNHHB5BWAMQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3149/review/306876405@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3149@github.com>
References: <quicwg/base-drafts/pull/3149@github.com>
Subject: Re: [quicwg/base-drafts] Explicit linkages for ODCID/OCID TP (#3149)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db217f5a17e3_1fb23fb1886cd9687279f2"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/25JaSXIlzVG3CN_aaCVB7FS7-GM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Oct 2019 21:30:33 -0000

martinthomson requested changes on this pull request.

There's a conflict imminent here.

> @@ -4412,9 +4412,10 @@ The following transport parameters are defined:
 original_connection_id (0x0000):
 
 : The value of the Destination Connection ID field from the first Initial packet
-  sent by the client.  This transport parameter is only sent by a server.  A
-  server MUST include the original_connection_id transport parameter if it sent
-  a Retry packet.
+  sent by the client.  This transport parameter is only sent by a server.  This
+  is the same value sent in the "Original Destination Connection ID" field of a
+  Retry packet (see {{packet-retry}}).  A server MUST include the

Note that David's proposal for integrity protection of the Retry packet changes this text to point to the original Initial sent by the client.  You should probably do the same.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3149#pullrequestreview-306876405