Re: [quicwg/base-drafts] Bring back the Exclusive Flag (#2781)

[Mike Bishop <[e-mail]>]

MikeBishop commented on this pull request.

Minor things; overall, looks good!

> @@ -620,9 +625,8 @@ When a prioritized element is first created, it has a default initial weight of
 orphan placeholder; pushes are dependent on the client request on which the
 PUSH_PROMISE frame was sent.
 
-Requests may override the default initial values by including a PRIORITY frame
-(see {{frame-priority}}) at the beginning of the stream. These priorities
-can be updated by sending a PRIORITY frame on the control stream.
+Requests may override the default initial values by sending a PRIORITY frame

Including it at stream creation is overriding the default priority.  I think I'd just call this "update" and say that everything has default priority when it's first created.

```suggestion
Priorities can be updated by sending a PRIORITY frame
```
\+ reflow

> @@ -1192,7 +1191,6 @@ of the associated Element ID fields.
 | 00      | Request stream   | Stream ID                       |
 | 01      | Push stream      | Push ID                         |
 | 10      | Placeholder      | Placeholder ID                  |
-| 11      | Current stream   | Absent                          |

Since the value of `11` was the only difference between these, we could re-combine them to a single table and simply say that prioritizing Root is invalid.  (Which you already have on line 1213.)

> @@ -1984,10 +1977,9 @@ commutative, both sender and receiver must apply them in the same order to
 ensure that both sides have a consistent view of the stream dependency tree.
 HTTP/2 specifies priority assignments in PRIORITY frames and (optionally) in
 HEADERS frames. To achieve in-order delivery of priority changes in HTTP/3,
-PRIORITY frames are sent as the first frame on a request stream or on the
-control stream and exclusive prioritization has been removed. HTTP/3 permits the
+PRIORITY frames are sent or on the control stream.  HTTP/3 permits the

```suggestion
PRIORITY frames are sent on the control stream.  HTTP/3 permits the
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2781#pullrequestreview-248467903