Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)

martinduke <notifications@github.com> Fri, 05 April 2019 14:29 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DE729120250 for <quic-issues@ietfa.amsl.com>; Fri, 5 Apr 2019 07:29:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1cNuPyNxTujn for <quic-issues@ietfa.amsl.com>; Fri, 5 Apr 2019 07:29:19 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E33641201E6 for <quic-issues@ietf.org>; Fri, 5 Apr 2019 07:29:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=QpDdVAq3Krbl1c3MhR4DtV4emPc=; b=nZzaNZ/xPKoIoGE9 WEqtHjlWzf8eh4+oOCLOqeTVLhnK5UJkzQ71XdlClhjyI5yLgktMEcD7x6+eU2Y1 SGrtJipmNUEQ+iz951wJd8hxgLiJefdpO9S1V+xmko9AYFAYDR/SPx3ezYtJfcks IZYNWsOb8zovLV/ZZoMG5ItccFE=
Received: by filter0527p1iad2.sendgrid.net with SMTP id filter0527p1iad2-1856-5CA7663C-4E 2019-04-05 14:29:16.914503312 +0000 UTC m=+725537.776337134
Received: from github-lowworker-8f847b2.cp1-iad.github.net (unknown [192.30.252.41]) by ismtpd0030p1mdw1.sendgrid.net (SG) with ESMTP id y9q_uadTTMKAbPJntbvF9Q for <quic-issues@ietf.org>; Fri, 05 Apr 2019 14:29:16.459 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-8f847b2.cp1-iad.github.net (Postfix) with ESMTP id BAEA1360067 for <quic-issues@ietf.org>; Fri, 5 Apr 2019 07:29:16 -0700 (PDT)
Date: Fri, 05 Apr 2019 14:29:17 +0000
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcd23506a4725175190e9cfb3d1857cc1bdbec53892cf0000000118bf283c92a169ce199da23e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2590/review/223307313@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2590@github.com>
References: <quicwg/base-drafts/pull/2590@github.com>
Subject: Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ca7663cb7665_5e783fd945cd45c0448733"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3OoSSriaqehPT0eE8e2gNR7pnab/b6ZlgWJQ GUKOia6LmeE9RPoOe7JBbeQOjXYmvpRiUrsKLOFuVsqLFJNNsP1VhhlPR8GrPf7+cPGwujHcUag0ls pChqONq0MY4cXyi2m0AXxekZj5mZxTOStMKG3R8E5XYHJJyeWZzn8jFmwPIOVurN7BVZbgiqXLBMBX U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2Jh6sQpWJ9c40t011egFhwKfi2w>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Apr 2019 14:29:21 -0000

martinduke commented on this pull request.



> @@ -458,11 +458,11 @@ sent, then no alarm should be armed until data has been received from the
 client.
 
 Because the server could be blocked until more packets are received, the client
-MUST start the crypto retransmission timer even if there is no unacknowledged
-CRYPTO data.  If the timer expires and the client has no CRYPTO data to
-retransmit and does not have Handshake keys, it SHOULD send an Initial packet in
-a UDP datagram of at least 1200 bytes.  If the client has Handshake keys, it
-SHOULD send a Handshake packet.
+MUST start the crypto retransmission timer until it has 1RTT keys, even if there

There would be outstanding CRYPTO data, so it would restart the timer and then send.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2590#discussion_r272613388