Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)
ianswett <notifications@github.com> Sat, 17 March 2018 22:37 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A9ECC12D87F for <quic-issues@ietfa.amsl.com>; Sat, 17 Mar 2018 15:37:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.008
X-Spam-Level:
X-Spam-Status: No, score=-7.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bo6IX9Q7CPtA for <quic-issues@ietfa.amsl.com>; Sat, 17 Mar 2018 15:37:26 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2F9FB12D7F6 for <quic-issues@ietf.org>; Sat, 17 Mar 2018 15:37:26 -0700 (PDT)
Date: Sat, 17 Mar 2018 15:37:25 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1521326245; bh=gQ2H2NN3RQTLu2R0rd7aYW4jGe/32t24YORw7fO13G0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SMcwOgahB0IOYjOrLJpeamb4FZU0Ymxt+lCc9zXPSDeP1MSqK4euqgmQhuK6Y3uxN 9lAdlwYUYeRM51UF6d3MIjb4xVn1dPKBiX4zKNij7F9Z+jv7ru0FFtILmZhzOQio6Q BUcoTFtIaT3Z2dqYfQVJrH/X0gSaaO10nu4Vt1rs=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6d4d1320d40d97fe9159ac0d27088525b5c1f46492cf0000000116c55aa592a169ce123fc47f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1223/review/104780136@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1223@github.com>
References: <quicwg/base-drafts/pull/1223@github.com>
Subject: Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aad98a51f20d_e833fb0c3708f385024b4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2NKcDClX4_cc9pwUehit-GHieak>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Mar 2018 22:37:28 -0000
ianswett commented on this pull request. Two comments. > @@ -834,19 +834,19 @@ DetectLostPackets(largest_acked): foreach (unacked < largest_acked.packet_number): time_since_sent = now() - unacked.time_sent delta = largest_acked.packet_number - unacked.packet_number - if (time_since_sent > delay_until_lost): - lost_packets.insert(unacked) - else if (delta > reordering_threshold) + if (time_since_sent > delay_until_lost || + delta > reordering_threshold): I think the convention is to indent the second line of the condition 2 more than the first? > lost_packets.insert(unacked) + sent_packets.remove(unacked.packet_number) + if (!unacked.is_ack_only): + lost_packets.insert(unacked) You already inserted this packet 3 lines above. Did you mean to remove that line? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1223#pullrequestreview-104780136
- [quicwg/base-drafts] don't apply congestion penal… Marten Seemann
- Re: [quicwg/base-drafts] don't apply congestion p… ianswett
- Re: [quicwg/base-drafts] don't apply congestion p… Marten Seemann
- Re: [quicwg/base-drafts] don't apply congestion p… Marten Seemann
- Re: [quicwg/base-drafts] don't apply congestion p… Marten Seemann
- Re: [quicwg/base-drafts] don't apply congestion p… ianswett
- Re: [quicwg/base-drafts] don't apply congestion p… Marten Seemann
- Re: [quicwg/base-drafts] don't apply congestion p… Marten Seemann
- Re: [quicwg/base-drafts] don't apply congestion p… ianswett
- Re: [quicwg/base-drafts] don't apply congestion p… ianswett
- Re: [quicwg/base-drafts] don't apply congestion p… Marten Seemann
- Re: [quicwg/base-drafts] don't apply congestion p… ianswett
- Re: [quicwg/base-drafts] don't apply congestion p… ianswett