Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)
MikkelFJ <notifications@github.com> Mon, 19 March 2018 11:36 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 967611276AF for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 04:36:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.008
X-Spam-Level:
X-Spam-Status: No, score=-2.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8j3SrnT_Fa5F for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 04:36:01 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5090F127077 for <quic-issues@ietf.org>; Mon, 19 Mar 2018 04:36:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Z0SVe4uivjSh353DXlRp2pDwBxA=; b=gROQ66rJf5VqVBWW ke2iqG8MXSLqkk1VhORqGFObU4fSRkPly0p9Vph8DWiZ5HmCp6EXzWOEFkVWIOFW QtzeDM9ko43BS6UjnbzyRGcDKtx1aqVwA/8Zqy+yRjDZU40Tdf1bFrPl4amiJWOm Lw+kkFfE69j0OAB76heWjM7f0vY=
Received: by filter0457p1las1.sendgrid.net with SMTP id filter0457p1las1-6480-5AAFA0A0-3 2018-03-19 11:36:00.085986825 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0049p1mdw1.sendgrid.net (SG) with ESMTP id QtsU0e19QhGFPYujzTaLHA for <quic-issues@ietf.org>; Mon, 19 Mar 2018 11:35:59.974 +0000 (UTC)
Date: Mon, 19 Mar 2018 11:36:00 +0000
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd0e4f360a00f8723953ddc4c2c84fdbd4ca75ed792cf0000000116c7629f92a169ce12418d6a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1231/review/104925314@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1231@github.com>
References: <quicwg/base-drafts/pull/1231@github.com>
Subject: Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aafa09faad30_60b02ab5c18a0ed419095"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0S+x9MuCNx40AzyVJZlTD4wqWoLBh1K5h3EF 4558dogE66OKvlXFbNpphUqIWyeXTYTXuxK1sNH+jHnX/N0V6bObvGylRfmFg7U1veg9QexJp4y5qv 7rFIT/hrRN/0IuFWSN+Zw8U2UqnkW1KFhBu6y4OH2IOQJQc1qVUwpYnvI/clWQiNNWJMz1xLhTJe1W I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2PBJmHkif1VjGhSSCuLewJzmjRs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 11:36:03 -0000
mikkelfj commented on this pull request. > To limit ACK blocks to those that have not yet been received by the sender, the receiver SHOULD track which ACK frames have been acknowledged by its peer. Once an ACK frame has been acknowledged, the packets it acknowledges SHOULD NOT be acknowledged again. -A receiver that is only sending ACK frames will not receive acknowledgments for -its packets. Sending an occasional MAX_DATA or MAX_STREAM_DATA frame as data is -received will ensure that acknowledgements are generated by a peer. Otherwise, -an endpoint MAY send a PING frame once per RTT to solicit an acknowledgment. +Because ACK-only packets are not acknowledged, a receiver that is only +sending ACK frames will only receive acknowledgements for its packets +if the sender piggybacks them on other packets. In order to enable I think that is an unfortunate requirement (SHOULD NOT be ack'ed again): You want to ack packets again because you collapse gaps into larger blocks. Only the oldest ACK'ed block should not be acked again. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1231#discussion_r175404347
- [quicwg/base-drafts] Restrict ACK-clocking to ACK… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Martin Thomson
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ianswett
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Marten Seemann
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ianswett
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ianswett
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Marten Seemann
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… MikkelFJ
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Martin Thomson
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… MikkelFJ
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Marten Seemann
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Martin Thomson
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Martin Thomson
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ianswett
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Martin Thomson