IETF Logo Mail Archive

Re: [quicwg/base-drafts] Allow servers to send a preferred address of each address family (#2296)

Dmitri Tikhonov <notifications@github.com> Wed, 09 January 2019 17:19 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 38A52130F4C for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 09:19:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.935
X-Spam-Level:
X-Spam-Status: No, score=-5.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9vuWctWRi6qe for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 09:19:17 -0800 (PST)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 20E2E130EB1 for <quic-issues@ietf.org>; Wed, 9 Jan 2019 09:19:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=6mTuJ7bQVY/xdhPOIwe/2CrKPEU=; b=mqBg7wLTX6yHdDvp kIqZQ+L2WEj1+l3eGD30U2ex0L3NkerHGrEDBdnBUZMocj2NorzXjkH+RTnqcFPj W4ywtYUfMwny9VqxxFiTrC8N99tj0RwHdTnrdsrE1knyyjPI5zP0TqzOpB//AYBP ZKukyLS+qS2X/iS36ECjLmuxNKg=
Received: by filter1642p1mdw1.sendgrid.net with SMTP id filter1642p1mdw1-21553-5C362D12-2D 2019-01-09 17:19:14.905400088 +0000 UTC m=+143782.849447000
Received: from github-lowworker-5909e27.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0024p1iad2.sendgrid.net (SG) with ESMTP id qa3aZm9WTnWT2yRGS_nLzg for <quic-issues@ietf.org>; Wed, 09 Jan 2019 17:19:14.861 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-5909e27.cp1-iad.github.net (Postfix) with ESMTP id D5F933E0016 for <quic-issues@ietf.org>; Wed, 9 Jan 2019 09:19:14 -0800 (PST)
Date: Wed, 09 Jan 2019 17:19:14 +0000
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb86ea4f1b4e597dc66987b505164be5f842fa05892cf00000001184def1292a169ce179bec73@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2296/review/190829010@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2296@github.com>
References: <quicwg/base-drafts/pull/2296@github.com>
Subject: Re: [quicwg/base-drafts] Allow servers to send a preferred address of each address family (#2296)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c362d12d2905_58fd3f98f22d45b89117af"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0XWESy1WrbtxDDPUsrECtQNXcCMc2DZgZeaJ LnK2pBQYt68TjakV6jiq1DjJzE5NKk/0un8/E10TayxH97hVHkXb90JdfQc5WK4q/rZPeMAp7evCkk i4GEN2lL5WViChNSBUGtI5B0ZE8emJ+IEIw8wkirHdUK1ftLgqFv+H8yiTx4w8ENc6VZ337pry2oWI o=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2Th42opFlr9EbTi7CA9sY2NrB5I>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 17:19:19 -0000

dtikhonov commented on this pull request.



>  
 ~~~
    struct {
-     enum { IPv4(4), IPv6(6), (15) } ipVersion;
-     opaque ipAddress<4..2^8-1>;
+     opaque ipv4Address<0..2^8-1>;
+     opaque ipv6Address<0..2^8-1>;
      uint16 port;

I'd err on the side of making it as generic as possible: that is, separate ports.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2296#discussion_r246461779

v2.23.0 | Report a Bug | By Email