[quicwg/base-drafts] encoder stream can deadlock (#1420)

Martin Thomson <notifications@github.com> Wed, 06 June 2018 14:11 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 94768130F2A for <quic-issues@ietfa.amsl.com>; Wed, 6 Jun 2018 07:11:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GjhQ8efkFoXe for <quic-issues@ietfa.amsl.com>; Wed, 6 Jun 2018 07:11:51 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 22C33130F27 for <quic-issues@ietf.org>; Wed, 6 Jun 2018 07:11:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ri/GXCcOi7dGy3FKODUPhDvWiBI=; b=rC6pwCButUvsYibf sRUEFqR+SkEd4psZWKNrf/z5nbE5dv37L8+SqNLyM7wqhFW11n99cSaJm5SpBUvK hc6l2boUEG6C9ltqOzTNH5Phg01XwJpZTpENV2DMLjViEaCRJixENYjPROxaPIv1 vmylK5jwr4EY5eUM3CAKhdCAbQI=
Received: by filter1094p1las1.sendgrid.net with SMTP id filter1094p1las1-16558-5B17EBA4-41 2018-06-06 14:11:48.641601043 +0000 UTC
Received: from github-lowworker-4f62d42.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0007p1iad1.sendgrid.net (SG) with ESMTP id aGHcpqUFSzOnGfHvvS2I7w for <quic-issues@ietf.org>; Wed, 06 Jun 2018 14:11:48.541 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-4f62d42.cp1-iad.github.net (Postfix) with ESMTP id 821A4C014A for <quic-issues@ietf.org>; Wed, 6 Jun 2018 07:11:48 -0700 (PDT)
Date: Wed, 06 Jun 2018 14:11:48 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab29d1e76fbe5189d3d72148f4ec7013ba2905c27792cf00000001172fada492a169ce13a9a7d1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1420@github.com>
Subject: [quicwg/base-drafts] encoder stream can deadlock (#1420)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b17eba4802e8_305a2ab5cb532f5433518e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2N+uL7VvBBJTXNqzgLej+O2cL4nH6CJdiZRD fRJS/wcOs4JNuwuLzZ7SEZL33tT3K4DcFqRLbv1HhRJ+pgMLY694GfIr3iulqJk2KX8MDi3BnP8RQ4 NXueNhhBekSyEUH/xIeVPA/1w8SqA4o9NcIZOAtpd/Hy8losrhnByi72+lcfeP/8FGcI7FEIJFlKvl M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2YfubkPr_MrephxAI5nd7twvEG8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jun 2018 14:11:55 -0000

If the encoder sends a large block that is bigger than the flow control limit AND the decoder doesn't read the block until all the data is present, THEN the decoder never releases flow control credit for the block, but the encoder can't complete sending of the block.  Deadlock.  Advise caution.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1420