Re: [quicwg/base-drafts] Recovery editorial pass (#2381)
ianswett <notifications@github.com> Tue, 29 January 2019 02:00 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DEAC812875B for <quic-issues@ietfa.amsl.com>; Mon, 28 Jan 2019 18:00:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2GZfYJPeMAnA for <quic-issues@ietfa.amsl.com>; Mon, 28 Jan 2019 18:00:04 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5B5C6130EF5 for <quic-issues@ietf.org>; Mon, 28 Jan 2019 18:00:04 -0800 (PST)
Date: Mon, 28 Jan 2019 18:00:03 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548727203; bh=/QZFNbMCP7uigElSCmip1pcsBukwyxPmomO9zHh5kVs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bb/6zKVXFf1p6nl5Y19ebwn2wZUSrVEKxC7QduMOxYQLRSeLKeLD7A8fGWz9FXbDv 38Vs5bHVo+V4aiiZwHxEgHxKsXVCrj+XeXz0rOIQqz2gZj5txby2gv6/LeG6CKsMJC vOeSwar++Dy/sPyfyKQmjR1oNKJOEV8g6DA3yRYQ=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab74f294df916a4bed4a92808614f9d7852308850192cf00000001186775a392a169ce1815c9b4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2381/review/197347825@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2381@github.com>
References: <quicwg/base-drafts/pull/2381@github.com>
Subject: Re: [quicwg/base-drafts] Recovery editorial pass (#2381)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4fb3a3761c9_5ed33fd6308d45b41448f6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2b5CNYhq2RliURtQTuRLeuAIw4E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jan 2019 02:00:07 -0000
ianswett commented on this pull request.
> @@ -454,10 +456,9 @@ a subsequent connection attempt to the server.
When packet protection keys are discarded (see Section 4.9 of {{QUIC-TLS}}), all
packets that were sent with those keys can no longer be acknowledged because
-their acknowledgements cannot be processed anymore. The sender considers them no
-longer in flight. That is, the sender SHOULD discard all recovery state
-associated with those packets and MUST remove them from the count of bytes in
-flight.
+their acknowledgements cannot be processed anymore. The sender SHOULD discard
+all recovery state associated with those packets and MUST remove them from
Fixed
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2381#discussion_r251666891
- [quicwg/base-drafts] Recovery editorial pass (#23… ianswett
- Re: [quicwg/base-drafts] Recovery editorial pass … Marten Seemann
- Re: [quicwg/base-drafts] Recovery editorial pass … ianswett
- Re: [quicwg/base-drafts] Recovery editorial pass … Marten Seemann
- Re: [quicwg/base-drafts] Recovery editorial pass … ianswett
- Re: [quicwg/base-drafts] Recovery editorial pass … ianswett
- Re: [quicwg/base-drafts] Recovery editorial pass … Jana Iyengar
- Re: [quicwg/base-drafts] Recovery editorial pass … Jana Iyengar