Re: [quicwg/base-drafts] QPACK table lookup noob clarifications (#2438)

Lucas Pardue <notifications@github.com> Fri, 08 February 2019 21:20 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7C0B1293B1 for <quic-issues@ietfa.amsl.com>; Fri, 8 Feb 2019 13:20:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bz7uA58wxHRS for <quic-issues@ietfa.amsl.com>; Fri, 8 Feb 2019 13:20:29 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 766DD12426A for <quic-issues@ietf.org>; Fri, 8 Feb 2019 13:20:29 -0800 (PST)
Date: Fri, 08 Feb 2019 13:20:28 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549660828; bh=HVCZHDS2wFLOriy8xYF+2x7cTGsIS5B8AyDBzLgEwUY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=H7j9gbmmpy7Cpr/Lx4cOLu1fWRn9AU/cytP9hnFl7uJ26XIARxnSh9FbWNRvobdzu Lni8/HCAyv63wzJ9ZkCGp7yi8L2n7jC3wiTNm5wzU5w8yCNarB3JNXteP5EgfHVmCZ 2sjQ6cNUczW61bGo1ITv/TS5kwiLR6yA+pS/GS/Q=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8ec10104fb3703147b79a5fd7ef964cff8177e6592cf000000011875b49c92a169ce1853f768@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2438/review/201790085@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2438@github.com>
References: <quicwg/base-drafts/pull/2438@github.com>
Subject: Re: [quicwg/base-drafts] QPACK table lookup noob clarifications (#2438)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5df29cb542f_b4e3fedefcd45c0517f9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2kIXlRdEiWQY5alMcbpWWd6oZSc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Feb 2019 21:20:31 -0000

LPardue commented on this pull request.



> @@ -963,6 +963,9 @@ followed by the `S` bit indicating whether the reference is into the static
 field is represented as an integer with a 6-bit prefix (see Section 5.1 of
 [RFC7541]).
 
+If the entry in the static or dynamic table does not provide any header field
+value (as opposed to a name), a zero-length string MUST be used.
+

I think the "problem case" is referencing a static table item with empty value. We discussed how to build the header list and felt that it it the job of the H3 endpoint to validate the header list, not QPACKs. This change makes it clear what to do, and what H3 could check in validation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2438#discussion_r255239003