Re: [quicwg/base-drafts] Compare H2 PROTOCOL_ERROR with HTTP_GENERAL_PROTOCOL_ERROR (#2808)

Kazuho Oku <> Wed, 19 June 2019 12:46 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id F06B6120466 for <>; Wed, 19 Jun 2019 05:46:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.605
X-Spam-Status: No, score=-6.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id TgifoVBmH_KT for <>; Wed, 19 Jun 2019 05:46:55 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 122FF12007A for <>; Wed, 19 Jun 2019 05:46:54 -0700 (PDT)
Date: Wed, 19 Jun 2019 05:46:54 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1560948414; bh=m8fnXoA4uwDFKHFun4XzPbLMj0obWp7TewL0xp9la+g=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pR12q5gCUvhOarGSGnk+qyeCM+22FcytDbVdcAI9xl2jGLQQo00rkKNffFBglboFn TqaIBQuVCSeBV536wNhs2jyWxyDv5UvPQ9gPs2NdamMQjJRG44i/r+bFJjlIwfFOOR kxeZgm4oJ3P4MHwF0Mk8F+AYh7SqB+9NPpXDQEt8=
From: Kazuho Oku <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2808/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Compare H2 PROTOCOL_ERROR with HTTP_GENERAL_PROTOCOL_ERROR (#2808)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0a2ebe1c5da_53d83fa5af2cd9605527f5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 19 Jun 2019 12:46:57 -0000

kazuho commented on this pull request.

> @@ -2174,8 +2174,7 @@ NO_ERROR (0x0):
 : HTTP_NO_ERROR in {{http-error-codes}}.
-: No single mapping.  See new HTTP_MALFORMED_FRAME error codes defined in
-  {{http-error-codes}}.
+: HTTP_GENERAL_PROTOCOL ERROR in {{http-error-codes}}.

Isn't it still the case that we have multiple error codes that map to HTTP_GENERAL_PROTOCOL error in HTTP/2?

Or are we going to merge all the connection-level error codes that do not map to an error code in HTTP/2 (e.g., WRONG_STREAM, UNEXPECTED_FRAME, CLOSED_CRITICAL_STREAM) to HTTP_GENERAL_PROTOCOL?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: