IETF Logo Mail Archive

Re: [quicwg/base-drafts] Include handshake anti-deadlock logic in pseudocode (#2281)

ianswett <notifications@github.com> Sun, 06 January 2019 21:06 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 49E06130E1E for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 13:06:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ut1hxCCBExK4 for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 13:06:35 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9AD93130DBE for <quic-issues@ietf.org>; Sun, 6 Jan 2019 13:06:35 -0800 (PST)
Date: Sun, 06 Jan 2019 13:06:34 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546808794; bh=bPqiu2VObg+6Nd/TNmIq1FAIdNaQRG7qAngEi5rd4tQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TF4nnQjXGTmIJpjeYtkkdoVRYjmUQJeAqzxV67EzqFhNk7QV2/BhWfW5225yfC/kW XuRyUIx7+brEaRNerLxRBG4ZntB9VU6OTdgNrP3e/TIa0lzrju0VR5EcV8+k57s5Ur E3qLQH8oDtFo9UXI36U7KB31BCQ5D5k6cASVyos0=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5696af9e6e188cf6e75cc9433293b4fc5118158192cf00000001184a2fda92a169ce178befb2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2281/review/189644317@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2281@github.com>
References: <quicwg/base-drafts/pull/2281@github.com>
Subject: Re: [quicwg/base-drafts] Include handshake anti-deadlock logic in pseudocode (#2281)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c326ddac7085_37583f80ab8d45bc874171"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2nSDQHVlUgW5SSLuG48eya0MXYM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Jan 2019 21:06:37 -0000

ianswett commented on this pull request.



> @@ -778,13 +778,7 @@ Pseudocode for SetLossDetectionTimer follows:
 
 ~~~
  SetLossDetectionTimer():
-    // Don't arm timer if there are no ack-eliciting packets
-    // in flight.
-    if (no ack-eliciting packets in flight):
-      loss_detection_timer.cancel()
-      return
-
-    if (crypto packets are in flight):
+    if (crypto packets are in flight || handshaking client):

I agree the pseudocode doesn't match the text, but I think the term "handshaking client" is not specific enough a definition to use in the pseudocode.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2281#pullrequestreview-189644317

v2.14.0 | Report a Bug | By Email