Date: Fri, 06 Dec 2019 13:55:50 -0800
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK2YINWLQQCI4QGAZUN37AAONEVBNHHB7VMV2I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3287/review/328479288@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3287@github.com>
References: <quicwg/base-drafts/pull/3287@github.com>
Subject: Re: [quicwg/base-drafts] Keep RFC6928 informative (#3287)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5deace6670330_71c53ff7324cd95c3357e";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2rpk7_VTZesxRmt-RvR2_rFjP28>


----==_mimepart_5deace6670330_71c53ff7324cd95c3357e
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

janaiyengar commented on this pull request.



> @@ -1253,10 +1253,11 @@ papers, and common practice.  Some may need to be changed or negotiated
 in order to better suit a variety of environments.
 
 kInitialWindow:
-: Default limit on the initial amount of data in flight, in bytes.  Taken from
-  {{?RFC6928}}, but increased slightly to account for the smaller 8 byte
-  overhead of UDP vs 20 bytes for TCP.  The RECOMMENDED value is the minimum
-  of 10 * max_datagram_size and max(2 * max_datagram_size, 14720)).
+: Default limit on the initial amount of data in flight, in bytes.
+  This follows the analysis and recommendations in {{?RFC6928}}, increasing the
+  byte limit to account for the smaller 8 byte overhead of UDP compared to the
+  20 byte overhead for TCP.  The RECOMMENDED value is the minimum of
+  10 * max_datagram_size and max(2 * max_datagram_size, 14720)).

Swap these two sentences -- recommendation first, rationale afterwards.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3287#pullrequestreview-328479288
----==_mimepart_5deace6670330_71c53ff7324cd95c3357e
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@janaiyengar</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3287#discussion_r355047271">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1253,10 +1253,11 @@ papers, and common practice.  Some may need to be changed or negotiated
 in order to better suit a variety of environments.
 
 kInitialWindow:
-: Default limit on the initial amount of data in flight, in bytes.  Taken from
-  {{?RFC6928}}, but increased slightly to account for the smaller 8 byte
-  overhead of UDP vs 20 bytes for TCP.  The RECOMMENDED value is the minimum
-  of 10 * max_datagram_size and max(2 * max_datagram_size, 14720)).
+: Default limit on the initial amount of data in flight, in bytes.
+  This follows the analysis and recommendations in {{?RFC6928}}, increasing the
+  byte limit to account for the smaller 8 byte overhead of UDP compared to the
+  20 byte overhead for TCP.  The RECOMMENDED value is the minimum of
+  10 * max_datagram_size and max(2 * max_datagram_size, 14720)).
</pre>
<p>Swap these two sentences -- recommendation first, rationale afterwards.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3287?email_source=notifications&amp;email_token=AFTOJKY3LCTBKDSFDZVLMYLQXLC6NA5CNFSM4JW26XZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOKDEOA#pullrequestreview-328479288">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK7OYVOCH6ANLB6JOITQXLC6NANCNFSM4JW26XZQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKYXZKTIOCMXV7VQXKDQXLC6NA5CNFSM4JW26XZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOKDEOA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3287?email_source=notifications\u0026email_token=AFTOJKY3LCTBKDSFDZVLMYLQXLC6NA5CNFSM4JW26XZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOKDEOA#pullrequestreview-328479288",
"url": "https://github.com/quicwg/base-drafts/pull/3287?email_source=notifications\u0026email_token=AFTOJKY3LCTBKDSFDZVLMYLQXLC6NA5CNFSM4JW26XZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOKDEOA#pullrequestreview-328479288",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5deace6670330_71c53ff7324cd95c3357e--