IETF Logo Mail Archive

Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)

Kazuho Oku <notifications@github.com> Thu, 03 January 2019 04:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A276B1310BA for <quic-issues@ietfa.amsl.com>; Wed, 2 Jan 2019 20:58:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I4ml8Wui2Gi3 for <quic-issues@ietfa.amsl.com>; Wed, 2 Jan 2019 20:58:13 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0AED51310B7 for <quic-issues@ietf.org>; Wed, 2 Jan 2019 20:58:13 -0800 (PST)
Date: Wed, 02 Jan 2019 20:58:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546491492; bh=m2yvrxecBqWKpvTOOYWVxRfn+T4edE3kSoo/LpPJ0fc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=se8/aQrQAKYu1M7rEBoGfZ471MGMcuMYGabxLHkNrmDTbQAfBUr+FT23m/68cYhE7 rJBE+RLSagCnayHvF2K24Qx4K3izLmeoakudXXwlCZ0CpKicsWWjIaTHV60r38SFyu fJpEnn/I3G89SjzrGs00B1IVP4ITxQfMdv3JZstE=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba34587f47d46ac773114e6af4abf27a82a3d56ac92cf000000011845586492a169ce1791b3a4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2285/c451056182@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2285@github.com>
References: <quicwg/base-drafts/pull/2285@github.com>
Subject: Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c2d9664408d9_34e03fecbfad45bc88982"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2x45jBshUO4kLxXAQTmoKkaueWI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jan 2019 04:58:15 -0000

I think that "end offset" might be ambiguous the same way as "final offset" is; it could mean the offset of the final octet. Using terms like "size" (or "number of bytes") avoids that confusion. It should also be noted that we refer to the same thing as "amount of data that can be sent" in the definition of MAX_STREAM_DATA; so far I have tried to align the definition of RESET_STREAM to that.

@martinthomson's suggestion to use "flow control credit" as a term sounds good to me. Ideally we should RESET_STERAM.final_offset and MAX_STREAM_DATA.max_stream_data using the same term.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2285#issuecomment-451056182

v2.23.0 | Report a Bug | By Email