Re: [quicwg/base-drafts] Minor editorializing of CID authentication (#3732)

Nick Banks <notifications@github.com> Fri, 05 June 2020 14:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B53C03A0433 for <quic-issues@ietfa.amsl.com>; Fri, 5 Jun 2020 07:50:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UFCijYYCbVld for <quic-issues@ietfa.amsl.com>; Fri, 5 Jun 2020 07:50:04 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7F08F3A00C4 for <quic-issues@ietf.org>; Fri, 5 Jun 2020 07:50:04 -0700 (PDT)
Received: from github-lowworker-b2150d3.ash1-iad.github.net (github-lowworker-b2150d3.ash1-iad.github.net [10.56.113.12]) by smtp.github.com (Postfix) with ESMTP id 6D28F8C0429 for <quic-issues@ietf.org>; Fri, 5 Jun 2020 07:50:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1591368603; bh=1P7dGHB3dK/euEeuqggvhoeAMos/BSpCboMR8TlOWY0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LfAfp/H3CiYOH4WeFnSSKifVqXVdAcP6Zd79/jwlwJmM9CDPEVKVxEbmPVpjgdY9e McmA76vqlM2pMi1H8NgCbJkcJ3CW2DZGbSaOlZ/z9VGoi17q6DamDOmxQ65HlN62Dj PHrsz2/1K9kHCELZwODw7KY6zgAL9Vz9mOm4o5QI=
Date: Fri, 05 Jun 2020 07:50:03 -0700
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYYSW334FGWH74DKPN44Y6JXEVBNHHCLIWN7E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3732/review/425370485@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3732@github.com>
References: <quicwg/base-drafts/pull/3732@github.com>
Subject: Re: [quicwg/base-drafts] Minor editorializing of CID authentication (#3732)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eda5b9b5ddba_30453fa69b0cd95c273479"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2yyTqvRF0NF_YCNM7hqd3_OtCwI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jun 2020 14:50:06 -0000

@nibanks approved this pull request.

Looks good, but I think the paragraph on lines 1574 to 1582 might be best split too, into sub-paragraphs for each TP and how it's used.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3732#pullrequestreview-425370485