From nobody Tue Mar  3 13:07:27 2020
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 6E2C13A0994
 for <quic-issues@ietfa.amsl.com>; Tue,  3 Mar 2020 13:07:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level: 
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id wBppjj1Oc_Zp for <quic-issues@ietfa.amsl.com>;
 Tue,  3 Mar 2020 13:07:24 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 32F823A0993
 for <quic-issues@ietf.org>; Tue,  3 Mar 2020 13:07:24 -0800 (PST)
Date: Tue, 03 Mar 2020 13:07:23 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1583269643;
 bh=suVH59HlmIxgrHRV6aq0/XteaJn0f8mmYazsL2jw5jc=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=IHCsBJnTjb+yLhdXx+dzAeCpYyiEbrkQnLNRhopV8XugOkKPrXsBFFWy6YbY+kRVj
 pZO5FGJ1c3luaUtrWlcu8LyuIyd0AYYPGKiRfChAdxVhABz8MXXmdSJ+f8LnGsNLQg
 EzS80oGIKY14l7LrSRA92S3n5m1M2jh5RJMzMvLA=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKYLYKTJSHWLXV3BLB54NKUAXEVBNHHCEP523U@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3493/review/368324420@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3493@github.com>
References: <quicwg/base-drafts/pull/3493@github.com>
Subject: Re: [quicwg/base-drafts] Add reference to RFC2914 in sec
 consideration sec (#3493)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e5ec70bd758_2f9f3fedae4cd96c93489";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2zcoFfajaSEoYu-GiWnbKDAId_U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Mar 2020 21:07:26 -0000


----==_mimepart_5e5ec70bd758_2f9f3fedae4cd96c93489
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -822,6 +822,11 @@ loss and ECN codepoints -- from unauthenticated entities.  On-path attackers can
 spoof or alter these signals.  An attacker can cause endpoints to reduce their
 sending rate by dropping packets, or alter send rate by changing ECN codepoints.
 
+Congestion control is essential to to avoid an congestion collapse of

```suggestion
Congestion control is essential to avoid congestion collapse of
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3493#pullrequestreview-368324420
----==_mimepart_5e5ec70bd758_2f9f3fedae4cd96c93489
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@ianswett</b> commented on this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3493#discussi=
on_r387293823">draft-ietf-quic-recovery.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -822,6 +822,11 @@ loss and ECN codepoin=
ts -- from unauthenticated entities.  On-path attackers can=0D
 spoof or alter these signals.  An attacker can cause endpoints to reduce=
 their=0D
 sending rate by dropping packets, or alter send rate by changing ECN cod=
epoints.=0D
 =0D
+Congestion control is essential to to avoid an congestion collapse of=0D=

</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-Congestion control is essential to to avoid a=
n congestion collapse of=0D
+Congestion control is essential to avoid congestion collapse of=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3493?email_source=3Dnotifications&amp;email_token=3DA=
FTOJKZF3JDXY5RDPIZVEYDRFVWQXA5CNFSM4LAINEYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCX2C6RA#pullrequestreview-368324420=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJK4NWJNR4QJUWC7ZTWDRFVWQXANCNFSM4LAINEYA">unsubscribe=
</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJKYEKQUA5RHU=
ATIED23RFVWQXA5CNFSM4LAINEYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWN=
FSXPKTDN5WW2ZLOORPWSZGOCX2C6RA.gif" height=3D"1" width=3D"1" alt=3D"" /><=
/p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3493?email_source=3D=
notifications\u0026email_token=3DAFTOJKZF3JDXY5RDPIZVEYDRFVWQXA5CNFSM4LAI=
NEYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC=
X2C6RA#pullrequestreview-368324420",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3493?email_source=3Dno=
tifications\u0026email_token=3DAFTOJKZF3JDXY5RDPIZVEYDRFVWQXA5CNFSM4LAINE=
YKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCX2=
C6RA#pullrequestreview-368324420",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5e5ec70bd758_2f9f3fedae4cd96c93489--

