Re: [quicwg/base-drafts] Gorry's ECN rewrite (#4059)

Gorry Fairhurst <notifications@github.com> Mon, 07 September 2020 11:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D518C3A0C26 for <quic-issues@ietfa.amsl.com>; Mon, 7 Sep 2020 04:37:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9vT6ZXYnaIOo for <quic-issues@ietfa.amsl.com>; Mon, 7 Sep 2020 04:37:18 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 807C53A0C27 for <quic-issues@ietf.org>; Mon, 7 Sep 2020 04:37:18 -0700 (PDT)
Received: from github-lowworker-943b171.ac4-iad.github.net (github-lowworker-943b171.ac4-iad.github.net [10.52.22.59]) by smtp.github.com (Postfix) with ESMTP id D566CE1E5A for <quic-issues@ietf.org>; Mon, 7 Sep 2020 04:37:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1599478637; bh=akqIHCBkOV3/OhRNKjZ+LFvGAA1sBEJE8Ygj9vrHsCo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=h+0rkYbvuvigbNrZ0AjmgcVO0IXgl3MjFl5f2EwS7B/XgUrupCo+tt8sR3KL/5Knq T+/7WBmtbuJhqSc3E8Kw53Iu3f0TN8TPVD5vGZu+EFvNPR1E9Uyx4zYvxnTXsUtMEk yan6YFPjTftzRrxeULyuZ4ZtH2B64gG1MIMdb/ak=
Date: Mon, 07 Sep 2020 04:37:17 -0700
From: Gorry Fairhurst <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4F76JAUU4BR7CL4V55MH6G3EVBNHHCR5CFZA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4059/c688268297@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4059@github.com>
References: <quicwg/base-drafts/pull/4059@github.com>
Subject: Re: [quicwg/base-drafts] Gorry's ECN rewrite (#4059)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f561b6dc62d3_42df19f014164a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gorryfair
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/30tG64w1B628dPup8xm9LNB3VF0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Sep 2020 11:37:20 -0000

Martin, (cc Lars)

I think, if I understand, that we now have text that is "mostly" 
correctable from the comments. I supect the proposed changes fix most 
(all?) of the confusion I originally had.  You own the edit token.

On 07/09/2020 12:27, Lars Eggert wrote:
>
> Who holds the pen on this PR?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
> <https://github.com/quicwg/base-drafts/pull/4059#issuecomment-688263251>, 
> or unsubscribe 
> <https://github.com/notifications/unsubscribe-auth/ABYLLEXJ7CRAILXKLKVZY4LSES7Q3ANCNFSM4QMZAVOA>.
>
* I don't think I have edit permission to fix the PR text where the PR 
comments propose a change, but you likely can edit!  - or you can make 
this possible for me to do, and I will re-edit these in.

* I think Mirja has a few remaining issues, which I think I'd sympathise 
with, but talking off-list I think the resolution of the comments in the 
PR edit may go a long way to alaso address these changes.

I don't know how best to progress, should we try to land the ECN rewrite 
making all agreed corrections, and then review what is left?

Gorry


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4059#issuecomment-688268297