Re: [quicwg/base-drafts] Change max_packet_size to max_datagram_size (#3471)

Nick Banks <notifications@github.com> Thu, 20 February 2020 14:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 320F0120073 for <quic-issues@ietfa.amsl.com>; Thu, 20 Feb 2020 06:58:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WdBUx98bMstf for <quic-issues@ietfa.amsl.com>; Thu, 20 Feb 2020 06:58:31 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2EBDB12003E for <quic-issues@ietf.org>; Thu, 20 Feb 2020 06:58:31 -0800 (PST)
Received: from github-lowworker-edec459.ac4-iad.github.net (github-lowworker-edec459.ac4-iad.github.net [10.52.18.32]) by smtp.github.com (Postfix) with ESMTP id 5D781960AB7 for <quic-issues@ietf.org>; Thu, 20 Feb 2020 06:58:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582210710; bh=cYrbrFiK6VUikA1CrowzJnriTeu5Bve7K6VLHOJqhno=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LFntV2qNmQarolM/0SDT/E9yGlCgct9A6z/z/TwLMKpIBiv05NWwFuQBXuD9g9w6z HY8E+nUr7wxubQ6BukWrGnYxYTO+2zQFtsLY5Rdr9p3eUPIpoffheBNq6s1VBGyzJR wbMFKeuxCqQqxrgtCmzuQJJv0CdUCcikzDdxR5/0=
Date: Thu, 20 Feb 2020 06:58:30 -0800
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7OEJU6QISISPDEW454LPIRNEVBNHHCDYABKU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3471/589092395@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3471@github.com>
References: <quicwg/base-drafts/issues/3471@github.com>
Subject: Re: [quicwg/base-drafts] Change max_packet_size to max_datagram_size (#3471)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e4e9e964e6b7_60a33f97bfacd9607405f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/30xkajHJ7kkBbd3mUcWBdpM6la8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Feb 2020 14:58:33 -0000

I agree. This seems like a good change, though I had already interpreted this value as "max UDP payload size" in the msquic code. I went back and looked at the text, and it's not 100% clear whether it was supposed to be for a QUIC packet or UDP datagram. It does say 'packet", not "datagram", but that word has been used interchangeably in the past...
```
max_packet_size (0x0003):
The maximum packet size parameter is an integer value that limits the size
of packets that the endpoint is willing to receive. This indicates that packets
larger than this limit will be dropped. The default for this parameter is the
maximum permitted UDP payload of 65527. Values below 1200 are invalid.
This limit only applies to protected packets (Section 12.1).
```
You might argue that it was always supposed to be UDP datagram payload length and call this editorial to clarify that, but calling it design is probably best.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3471#issuecomment-589092395