Date: Wed, 07 Jun 2017 04:46:19 -0700
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab023d1e9e39da59e73feb66b47c8e588604cc410492cf00000001154fa98b92a169ce0df481a1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/600/review/42577604@github.com>
In-Reply-To: <quicwg/base-drafts/pull/600@github.com>
References: <quicwg/base-drafts/pull/600@github.com>
Subject: Re: [quicwg/base-drafts] Split QUIC core from QUIC v1 (#600)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5937e78bd4033_57543fd130381c38344d4";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/34Y-O-EI-v0a-JvxylEvRnlyw3A>

----==_mimepart_5937e78bd4033_57543fd130381c38344d4
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

LPardue commented on this pull request.



>  The short header can be used after the version and 1-RTT keys are negotiated.
-This header form has the following fields:
-
-Header Form:
-
-: The most significant bit (0x80) of the first octet of a packet is the header
-  form.  This bit is set to 0 for the short header.
+The format of the long-form header is described in {{QUIC-CORE}}.

nit: short-form header

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/600#pullrequestreview-42577604
----==_mimepart_5937e78bd4033_57543fd130381c38344d4
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@LPardue</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/600#discussion_r120602876">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt;  The short header can be used after the version and 1-RTT keys are negotiated.
-This header form has the following fields:
-
-Header Form:
-
-: The most significant bit (0x80) of the first octet of a packet is the header
-  form.  This bit is set to 0 for the short header.
+The format of the long-form header is described in {{QUIC-CORE}}.
</pre>
<p>nit: short-form header</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/600#pullrequestreview-42577604">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq6Sz_GNPDKdhMywqr7heQXp7GBf9ks5sBo2LgaJpZM4NyWse">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AWbkq3p1SNOuMPgYgNDPnFFaNZ_V3aekks5sBo2LgaJpZM4NyWse.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/quicwg/base-drafts/pull/600#pullrequestreview-42577604"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@LPardue commented on #600"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/600#pullrequestreview-42577604"}}}</script>
----==_mimepart_5937e78bd4033_57543fd130381c38344d4--