Re: [quicwg/base-drafts] Fix bug in Insert Count Increment description. (#3132)

afrind <notifications@github.com> Tue, 29 October 2019 21:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C5BD5120289 for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 14:10:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YY3C-kBkgL-K for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 14:10:11 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 04BFD12006D for <quic-issues@ietf.org>; Tue, 29 Oct 2019 14:10:11 -0700 (PDT)
Date: Tue, 29 Oct 2019 14:10:10 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572383410; bh=Ly/SqfzFpK1V2gmjRwvqLyfyCTgFBsS4Kg8RcW7M5cw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zns5mxGjN9bFs8IirRSVusR1wgo7CyXHLPx6ycwkn1eGDZjpAotcQ3VIT1PIUA0go wtj44ZWZMkLhTeG6Ms9lqN9l/hmU+2cEWyE4uWfz9V51a3L+puPDNuj+/wdzejKASW jbjEmyUZ+0vWbC3tF2gZJzZEHoyrX4WI4HJE8wWE=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2LXCWHR5JNTNEQ5VN3YXVUFEVBNHHB45IKMY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3132/review/308833858@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3132@github.com>
References: <quicwg/base-drafts/pull/3132@github.com>
Subject: Re: [quicwg/base-drafts] Fix bug in Insert Count Increment description. (#3132)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db8aab21f62a_b9f3f82258cd96c5870"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3AZv_yzmaXKUPVkDjDK9bU1re_8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 21:10:13 -0000

afrind commented on this pull request.



>  
-If a header block was potentially blocking, the encoder infers from receiving a
-Header Acknowledgement instruction ({{header-acknowledgement}}) that the decoder
-has received all dynamic table state necessary to process that header block.  If
-the Required Insert Count of the acknowledged header block is greater than the
-current Known Received Count, the encoder updates the Known Received Count to
-the value of the Required Insert Count of the acknowledged header block.
+The Known Received Count is the total number of acknowledged dynamic table
+insertions and duplications.  It is updated using Header Acknowledgement

I'm not sure it was wrong before to say it's the number acknowledged by the decoder.   The decoder updates as it acknowledges, the encoder updates as it receives acknowledgements.  Without it, you need to read further to clarify that this is not the insert+dup count as sent by the encoder.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3132#pullrequestreview-308833858