Re: [quicwg/base-drafts] Rework flow of Push ID (#3925)

Mike Bishop <notifications@github.com> Wed, 22 July 2020 15:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C40873A097C for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 08:59:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Nb7EpGnkCWo for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 08:59:12 -0700 (PDT)
Received: from out-9.smtp.github.com (out-9.smtp.github.com [192.30.254.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9A16A3A0977 for <quic-issues@ietf.org>; Wed, 22 Jul 2020 08:59:12 -0700 (PDT)
Received: from github-lowworker-d1d6e31.ash1-iad.github.net (github-lowworker-d1d6e31.ash1-iad.github.net [10.56.105.50]) by smtp.github.com (Postfix) with ESMTP id 06396260477 for <quic-issues@ietf.org>; Wed, 22 Jul 2020 08:59:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595433552; bh=Wa/oX8m4jMP04mdbvhLkdiyay4KL5jCPFlyuxDqJqNU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FgSENXqzrquxHQ/6hSuBZAdM3sg8t81L3Xy+EyIKvPByzbSja8o1xTrKIM/RDYkLx DpSVTzCfN1sfESlVWIs1LWmT91euB0gEh79Rz1NTIp1g6W/DfY+om3wOLorS3f/ov7 jZTn9ralzSXP1u4NrN0q0giB3UetdG33LWcjzmKQ=
Date: Wed, 22 Jul 2020 08:59:11 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZAWOCGKHU62IPM4AV5ERBU7EVBNHHCPBRDMY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3925/review/453457697@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3925@github.com>
References: <quicwg/base-drafts/pull/3925@github.com>
Subject: Re: [quicwg/base-drafts] Rework flow of Push ID (#3925)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f18624fb46c6_67363f7f54ccd964168089"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3JBX2IVdwUuKcx0VyIxelsBR7AU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2020 15:59:14 -0000

@MikeBishop commented on this pull request.



> @@ -907,9 +910,9 @@ graceful shutdown of a connection by sending a GOAWAY frame ({{frame-goaway}}).
 The GOAWAY frame contains an identifier that indicates to the receiver the range
 of requests or pushes that were or might be processed in this connection.  The
 server sends a client-initiated bidirectional Stream ID; the client sends a Push
-ID.  Requests or pushes with the indicated identifier or greater are rejected by
-the sender of the GOAWAY.  This identifier MAY be zero if no requests or pushes
-were processed.
+ID ({{server-push}}).  Requests or pushes with the indicated identifier or

That reference informs the specific term, not the whole statement; I think the parentheses are more appropriate in this instance.

> +Push stream data can also arrive after a client has canceled a push. In this
+case, the client can abort reading the stream with an error code of

It has to be design if it prohibits something previously permitted or permits something previously prohibited.  A changed recommendation is hazier, and we've sometimes chosen to treat those as design for better visibility to make sure the WG is fully on-board, but they don't have to be.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3925#discussion_r458900246