Re: [quicwg/base-drafts] Change PTO to be per packet number space (#3066)
Martin Thomson <notifications@github.com> Thu, 24 October 2019 03:33 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D1FAE12010D for <quic-issues@ietfa.amsl.com>; Wed, 23 Oct 2019 20:33:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rfV0e7S75uo0 for <quic-issues@ietfa.amsl.com>; Wed, 23 Oct 2019 20:33:30 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 398061200F6 for <quic-issues@ietf.org>; Wed, 23 Oct 2019 20:33:30 -0700 (PDT)
Date: Wed, 23 Oct 2019 20:33:29 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571888009; bh=OiEy6XqIbXo1v6BoNsvxHx5dm/8ZhTptwQ2fcDRRPIg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VjnKCw7/lF2FsoPg9GcfTa7VMBrW63KQJmfo9oSZjUhdISKA6Y4sUmtcWnS0W28DC N7AEnSRb6QQ+C+yI4zrH1ZNbx71eaiiVd9ebzhJ2LCGe00DGBxEpSXcq1y1+iedsc9 GI67WCzWB84btX+sztESj2kZUYnKZlMunhdZeGg8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7IBYIR7JFE753SND53XZHATEVBNHHB3LP3EA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3066/review/306303081@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3066@github.com>
References: <quicwg/base-drafts/pull/3066@github.com>
Subject: Re: [quicwg/base-drafts] Change PTO to be per packet number space (#3066)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db11b8972ca8_5c0a3fafb90cd96c1648e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3NyB-f2aU_gLQRBHmgsZPK3uJDU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Oct 2019 03:33:32 -0000
martinthomson approved this pull request. > @@ -522,9 +525,17 @@ removed from bytes in flight when the Initial and Handshake keys are discarded. ### Sending Probe Packets When a PTO timer expires, a sender MUST send at least one ack-eliciting packet -as a probe, unless there is no data available to send. An endpoint MAY send up -to two full-sized datagrams containing ack-eliciting packets, to avoid an -expensive consecutive PTO expiration due to a single lost datagram. +in the packet number space as a probe, unless there is no data available to +send. An endpoint MAY send up to two full-sized datagrams containing +ack-eliciting packets, to avoid an expensive consecutive PTO expiration due +to a single lost datagram. + +In addition to sending data in the packet number space for which the timer +expired, the sender SHOULD coalesce ack-eliciting packets from all other packet +number spaces with in-flight data if sending coalesced packets is supported. +If implementations do not send coalesced packets upon timeout when multiple +packet number spaces have in-flight data, then they MUST only send a single @janaiyengar has it right, but repeats "PTO expiration", suggest: > If an endpoint has data in multiple packet number spaces in flight and is unable to send coalesced packet when a PTO expires, it MUST send only a single datagram. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3066#pullrequestreview-306303081
- [quicwg/base-drafts] Change PTO to be per packet … ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… David Schinazi
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… Martin Thomson
- Re: [quicwg/base-drafts] Change PTO to be per pac… Kazuho Oku
- Re: [quicwg/base-drafts] Change PTO to be per pac… MikkelFJ
- Re: [quicwg/base-drafts] Change PTO to be per pac… martinduke
- Re: [quicwg/base-drafts] Change PTO to be per pac… martinduke
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… Jana Iyengar
- Re: [quicwg/base-drafts] Change PTO to be per pac… Martin Thomson
- Re: [quicwg/base-drafts] Change PTO to be per pac… Jana Iyengar
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… Marten Seemann
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… martinduke
- Re: [quicwg/base-drafts] Change PTO to be per pac… Marten Seemann
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… David Schinazi
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… martinduke
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… martinduke
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… martinduke
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… martinduke
- Re: [quicwg/base-drafts] Change PTO to be per pac… Martin Thomson
- Re: [quicwg/base-drafts] Change PTO to be per pac… Jana Iyengar
- Re: [quicwg/base-drafts] Change PTO to be per pac… Jana Iyengar
- Re: [quicwg/base-drafts] Change PTO to be per pac… Junho Choi
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… Marten Seemann
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… Jana Iyengar
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… Marten Seemann
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… Marten Seemann
- Re: [quicwg/base-drafts] Change PTO to be per pac… Marten Seemann
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… Jana Iyengar
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett
- Re: [quicwg/base-drafts] Change PTO to be per pac… Jana Iyengar
- Re: [quicwg/base-drafts] Change PTO to be per pac… Jana Iyengar
- Re: [quicwg/base-drafts] Change PTO to be per pac… Marten Seemann
- Re: [quicwg/base-drafts] Change PTO to be per pac… ianswett