Re: [quicwg/base-drafts] Define stream limits as counts (#1906)

[Ryan Hamilton <[e-mail]>]

RyanAtGoogle commented on this pull request.



>  
-The maximum stream ID is specific to each endpoint and applies only to the peer
-that receives the setting. That is, clients specify the maximum stream ID the
-server can initiate, and servers specify the maximum stream ID the client can
-initiate.  Each endpoint may respond on streams initiated by the other peer,
-regardless of whether it is permitted to initiate new streams.
+The stream limit is specific to each endpoint and applies only to the peer that
+receives the setting. That is, clients limit the number of streams the server

Hm I'm not in love with the "number of streams" terminology. With "maximum stream ID" it was very obvious what was being limited. If the max stream ID was X, you clearly could not open a steam with ID X+1 (or X+4 but whatever :>).

With a limit on the "number of a streams" this is less clear. If a server limits the client to 10, presumably the idea is that this is equivalent to a max stream id limit of the 10th client initiated stream ID. But it also seems like you could read this limit to permit the client to open any 10 steams. Like 0, 40, 80, 120, ... I think this is not the intent, but the terminology makes this much less clear to me.

For example, the text below:

"A peer MUST NOT initiate a stream with a higher stream ID than the largest limit
maximum stream ID it has received. "

Clearly the limit applies to stream ID, but using "number of streams" seems to obscure that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1906#pullrequestreview-168612858