Re: [quicwg/base-drafts] ECN counts in the ACK frame should be in the same pn_space of the ACK frame (#2964)

Jana Iyengar <notifications@github.com> Tue, 13 August 2019 22:55 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 359831208C2 for <quic-issues@ietfa.amsl.com>; Tue, 13 Aug 2019 15:55:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zJpA0fqNlc2q for <quic-issues@ietfa.amsl.com>; Tue, 13 Aug 2019 15:55:25 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A496120922 for <quic-issues@ietf.org>; Tue, 13 Aug 2019 15:55:25 -0700 (PDT)
Date: Tue, 13 Aug 2019 15:55:24 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1565736924; bh=3Nn9uLepBm7bLzV3MkBWJAMTEOgiT+fHYpuD7HsK/u8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CLW+hQ6CSLOZcGDwh/V0Ny3Zp99UUJYoAACa4b9ofbgCtTKikmcAN5ScJovl5gMzz NqauA+jtwaENS6ZEkf9NBXMek/kmOXUB4xvGVRdDBTb5vtLvWJf8sSfB3dl+5ugR0K Bltn9K+eFHvsElNMAWHTxfTpqKF21FUfO2XpU1zU=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7M7A3HQXEX3LKWY4F3MBZFZEVBNHHBZD27OQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2964/review/274596637@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2964@github.com>
References: <quicwg/base-drafts/pull/2964@github.com>
Subject: Re: [quicwg/base-drafts] ECN counts in the ACK frame should be in the same pn_space of the ACK frame (#2964)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d533fdc5a13d_3edb3ffb2cecd96820616c"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3VUKNVwqhVqmhC00ts5pJpyy4yA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Aug 2019 22:55:27 -0000

janaiyengar commented on this pull request.

A few editorial suggestions, but looks good.

>  
 ECT(1) Count:
 : A variable-length integer representing the total number of packets received
-  with the ECT(1) codepoint.
+  with the ECT(1) codepoint in in the same packet number space of the ACK.

```suggestion
  with the ECT(1) codepoint in the packet number space of the ACK frame.
```

> @@ -4586,15 +4586,15 @@ The three ECN Counts are:
 
 ECT(0) Count:
 : A variable-length integer representing the total number of packets received
-  with the ECT(0) codepoint.
+  with the ECT(0) codepoint in the same packet number space of the ACK.

```suggestion
  with the ECT(0) codepoint in the packet number space of the ACK frame.
```

>  
 CE Count:
 : A variable-length integer representing the total number of packets received
-  with the CE codepoint.
+  with the CE codepoint in the same packet number space of the ACK.

```suggestion
  with the CE codepoint in the packet number space of the ACK frame.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2964#pullrequestreview-274596637