Re: [quicwg/base-drafts] Make language in ECN validation clearer (#3777)
Jana Iyengar <notifications@github.com> Thu, 18 June 2020 21:18 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB09B3A0FB0 for <quic-issues@ietfa.amsl.com>; Thu, 18 Jun 2020 14:18:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.899
X-Spam-Level: *
X-Spam-Status: No, score=1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GB_SUMOF=5, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JRAf1GMSuxxr for <quic-issues@ietfa.amsl.com>; Thu, 18 Jun 2020 14:18:11 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 758C13A0FAC for <quic-issues@ietf.org>; Thu, 18 Jun 2020 14:18:11 -0700 (PDT)
Received: from github-lowworker-1b8c660.ash1-iad.github.net (github-lowworker-1b8c660.ash1-iad.github.net [10.56.18.59]) by smtp.github.com (Postfix) with ESMTP id 90E6FE0AB8 for <quic-issues@ietf.org>; Thu, 18 Jun 2020 14:18:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1592515090; bh=mUqPClBd8/672fD9i8bKM+6N76GRKPjlkvdcn+wFR0c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=17/ZShlJKvtwVi4FVbrranva0Ls9APkjcbPHLg7Ms68V4Bs85nNONHLPC9eLwdiz5 zCqmDrgHpr6KTENLKrKqD0nsdOgjV6CywAf9Guk5HL1+F2yyNW/cxhad++FYkXAkUy jPJl8i+IEssSN+ITSvbAm5Ap9+AtpzuALGulmQu4=
Date: Thu, 18 Jun 2020 14:18:10 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4K6DS5VRJYVMWRNR54665RFEVBNHHCMM6BII@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3777/review/433642378@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3777@github.com>
References: <quicwg/base-drafts/pull/3777@github.com>
Subject: Re: [quicwg/base-drafts] Make language in ECN validation clearer (#3777)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eebda12820d2_1cdb3ffab34cd96435537d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3mkTNe4IjqK6KP_ioltTVztcC0E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2020 21:18:13 -0000
@janaiyengar approved this pull request. A few suggestions, but LGTM. > +An endpoint that sets ECT(0) or ECT(1) codepoints on packets records the ECN +counts it has received in ACK frames. When processing an ACK frame, the +endpoint MUST validate the increase in ECN counts based on the markings that +were applied to packets that are newly acknowledged. ```suggestion An endpoint that sets ECT(0) or ECT(1) codepoints on packets records the ECN counts it receives in ACK frames. When processing an ACK frame, the endpoint MUST validate any increases from previously received ECN counts, as follows: ``` ... and drop the line below about ECN validation. > -* For validation to succeed, the total increase in ECT(0), ECT(1), and CE counts - MUST be no smaller than the total number of QUIC packets sent with an ECT - codepoint that are newly acknowledged in this ACK frame. This step detects - any network remarking from ECT(0), ECT(1), or CE codepoints to Not-ECT. +* ECN validation fails if the sum of the increases to ECT(0), ECT(1), and CE + counts in the ACK frame are less than the number of newly acknowledged + packets that were sent with an ECT codepoint. This step detects any + network remarking from ECT(0), ECT(1), or CE codepoints to Not-ECT. ```suggestion erroneous network overwriting from ECT(0), ECT(1), or CE codepoints to Not-ECT. ``` > This step detects any erroneous network remarking from ECT(0) to ECT(1) (or vice versa). ```suggestion This step detects any erroneous network overwriting from ECT(0) to ECT(1) (or vice versa). ``` > + +ECN validation involves the following checks: ```suggestion ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3777#pullrequestreview-433642378
- [quicwg/base-drafts] Make language in ECN validat… Martin Thomson
- Re: [quicwg/base-drafts] Make language in ECN val… Martin Thomson
- Re: [quicwg/base-drafts] Make language in ECN val… Martin Thomson
- Re: [quicwg/base-drafts] Make language in ECN val… mirjak
- Re: [quicwg/base-drafts] Make language in ECN val… Jana Iyengar
- Re: [quicwg/base-drafts] Make language in ECN val… Martin Thomson
- Re: [quicwg/base-drafts] Make language in ECN val… Martin Thomson
- Re: [quicwg/base-drafts] Make language in ECN val… Martin Thomson
- Re: [quicwg/base-drafts] Make language in ECN val… Jana Iyengar
- Re: [quicwg/base-drafts] Make language in ECN val… Martin Thomson
- Re: [quicwg/base-drafts] Make language in ECN val… Martin Thomson
- Re: [quicwg/base-drafts] Make language in ECN val… Martin Thomson
- Re: [quicwg/base-drafts] Make language in ECN val… Jana Iyengar
- Re: [quicwg/base-drafts] Make language in ECN val… Martin Thomson
- Re: [quicwg/base-drafts] Make language in ECN val… Jana Iyengar
- Re: [quicwg/base-drafts] Make language in ECN val… Martin Thomson