Re: [quicwg/base-drafts] which -> that where appropriate & related nit fixes (#3964)
afrind <notifications@github.com> Tue, 28 July 2020 18:22 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 05B173A0B15 for <quic-issues@ietfa.amsl.com>; Tue, 28 Jul 2020 11:22:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.574
X-Spam-Level:
X-Spam-Status: No, score=-1.574 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tqAHka7MZG13 for <quic-issues@ietfa.amsl.com>; Tue, 28 Jul 2020 11:22:39 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C02AA3A0AE5 for <quic-issues@ietf.org>; Tue, 28 Jul 2020 11:22:39 -0700 (PDT)
Received: from github-lowworker-0f78100.ash1-iad.github.net (github-lowworker-0f78100.ash1-iad.github.net [10.56.25.48]) by smtp.github.com (Postfix) with ESMTP id 1668D600D11 for <quic-issues@ietf.org>; Tue, 28 Jul 2020 11:22:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595960559; bh=sqh8WNECsXR9t6h3w9qCKyoPv2B9Z482FbyP5JMgdIg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wNWCPqRGBMFE5HLym0F+88dauLgww4F4yHB4acyn4q2RxbPkn6XCgcaTc5BTkpcpz nsujCTnVoAGFHlU68eg3/cTkOvptXZ94IOoNn8JSHszcjNLyGXiN221uUHHAeysRhK ZvgspWXdcb3yRmTlrZHeoLDjmn2rQw5+LR5tSwKU=
Date: Tue, 28 Jul 2020 11:22:39 -0700
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3CA36GTOSYYB3FMGV5FRG67EVBNHHCPPU57M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3964/review/456894120@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3964@github.com>
References: <quicwg/base-drafts/pull/3964@github.com>
Subject: Re: [quicwg/base-drafts] which -> that where appropriate & related nit fixes (#3964)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f206cef7497_6b7716f811097e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3o3lNgN7beTc9Qoxp3q0lp2rT5o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2020 18:22:41 -0000
@afrind approved this pull request. QPACK changes look ok, with a minor comment > @@ -1153,7 +1153,7 @@ represented as a 4-bit prefix string literal, then the value, represented as an # Configuration -QPACK defines two settings which are included in the HTTP/3 SETTINGS frame. +QPACK defines two settings that are included in the HTTP/3 SETTINGS frame: Seems a bit strange, since it seems to imply that these SETTINGS are always present. Would this be better: "QPACK defines two settings for the HTTP/3 SETTINGS frame" ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3964#pullrequestreview-456894120
- Re: [quicwg/base-drafts] which -> that where appr… Lars Eggert
- [quicwg/base-drafts] which -> that where appropri… Lars Eggert
- Re: [quicwg/base-drafts] which -> that where appr… Martin Thomson
- Re: [quicwg/base-drafts] which -> that where appr… Martin Thomson
- Re: [quicwg/base-drafts] which -> that where appr… Lars Eggert
- Re: [quicwg/base-drafts] which -> that where appr… afrind
- Re: [quicwg/base-drafts] which -> that where appr… Jana Iyengar
- Re: [quicwg/base-drafts] which -> that where appr… Jana Iyengar
- Re: [quicwg/base-drafts] which -> that where appr… Lars Eggert
- Re: [quicwg/base-drafts] which -> that where appr… Lars Eggert
- Re: [quicwg/base-drafts] which -> that where appr… Mike Bishop
- Re: [quicwg/base-drafts] which -> that where appr… Mike Bishop
- Re: [quicwg/base-drafts] which -> that where appr… Mike Bishop
- Re: [quicwg/base-drafts] which -> that where appr… Mike Bishop
- Re: [quicwg/base-drafts] which -> that where appr… Jana Iyengar