Re: [quicwg/base-drafts] Move ack generation out of loss detection (#2027)

ianswett <notifications@github.com> Tue, 20 November 2018 20:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B02A012D4EF for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 12:39:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.469
X-Spam-Level:
X-Spam-Status: No, score=-8.469 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4UkPVUs4pQqu for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 12:39:03 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B567E12785F for <quic-issues@ietf.org>; Tue, 20 Nov 2018 12:39:03 -0800 (PST)
Date: Tue, 20 Nov 2018 12:39:02 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542746342; bh=dfIDWlFbCkbY/Sl4BNv9GefNxlO3z/XE8f36O+G5s+c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wwUzuB8XF5pUTYUXHvf/5FGExHcdZNrUNJPMvWQZRM/ItO0FQ6XSX0ww9maqLU80j C2lFmGpLX8cGLJT0k+uNVp1GeaZsn/DI67/riy9sqpyzCwvq5QKqlI0+lY7C2aqssm Pd2MN65S2UwG9V/UbmFUuRDyv+GhQoWF8BiuKWpo=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab759b89e1daa27125d705b1d144546f396bd24c7292cf00000001180c32e692a169ce16d1a61f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2027/review/176964211@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2027@github.com>
References: <quicwg/base-drafts/pull/2027@github.com>
Subject: Re: [quicwg/base-drafts] Move ack generation out of loss detection (#2027)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf470e6ed2a4_69663fc2826d45b4676888"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3s506VANOZTvjh6u-zerF-n28L0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 20:39:06 -0000

ianswett approved this pull request.

This LG, want to rewrite #2025 after you land this, since you had so many comments?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2027#pullrequestreview-176964211