Re: [quicwg/base-drafts] Cleaning up Loss Detection overview (#536)

ianswett <notifications@github.com> Fri, 19 May 2017 01:14 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E26C12EBBB for <quic-issues@ietfa.amsl.com>; Thu, 18 May 2017 18:14:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.78
X-Spam-Level:
X-Spam-Status: No, score=-4.78 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fcPMQQ8yiMSj for <quic-issues@ietfa.amsl.com>; Thu, 18 May 2017 18:14:18 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 286EB129498 for <quic-issues@ietf.org>; Thu, 18 May 2017 18:08:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=KOQMVJF/kwKnuwVTMxEnAZBantA=; b=DADXsE58PKp64NHO qrVZCZJMmZBD6YK51HahOjlAnK0Rd3jWO7p5c9v8osyQXMlmeJIuPiNdVpocf6ab aLjpob1nNScVJKusl07tl/c1T6zjS8ORYgy0Hknf5D0v6UZFVSZHlmTkDGmVDZ1Q ibCfcV8u60sE5NZ+D4NdoJW09WQ=
Received: by filter0602p1mdw1.sendgrid.net with SMTP id filter0602p1mdw1-7020-591E45A6-1 2017-05-19 01:08:54.021199938 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id 9YJvstk2QkmRE2ziNnCi2w for <quic-issues@ietf.org>; Fri, 19 May 2017 01:08:54.049 +0000 (UTC)
Date: Thu, 18 May 2017 18:08:53 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab73756bd15e9ac28fd78197677d62e77590f8211c92cf00000001153607a592a169ce0dada711@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/536/review/39090970@github.com>
In-Reply-To: <quicwg/base-drafts/pull/536@github.com>
References: <quicwg/base-drafts/pull/536@github.com>
Subject: Re: [quicwg/base-drafts] Cleaning up Loss Detection overview (#536)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_591e45a5edf62_5d3a3fddbc9efc30100390"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0Li+RLeR3AP19Qx42kTx3RQ3JygLJpdJ3BOd Sv0s0P1+HD65njKlIVGqIM5+S5JST3GkyinXQXVziEtKAWiYVEoV+bNABCdLE5xh1cnNzEygtiNNr1 OVzxA0tVZ7t7OBUEoNil0GGcFGlU56e67M7tVccA4/Zf1FVhbtjrE2SEKUlEyw2L9tYtA9+sE9SE8i I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/40tUYlUtx4wKgEI5Pv4Db9CcB9Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 May 2017 01:14:20 -0000

ianswett commented on this pull request.



>  QUIC uses a combination of ack information and alarms to detect lost packets.
 An unacknowledged QUIC packet is marked as lost in one of the following ways:
 
-  * A packet is marked as lost if at least one packet that was sent a threshold
-    number of packets (kReorderingThreshold) after it has been
-    acknowledged. This indicates that the unacknowledged packet is either lost
-    or reordered beyond the specified threshold. This mechanism combines both
-    TCP's FastRetransmit and FACK mechanisms.
-
-  * If a packet is near the tail, where fewer than kReorderingThreshold packets
-    are sent after it, the sender cannot expect to detect loss based on the
-    previous mechanism. In this case, a sender uses both ack information and an
-    alarm to detect loss. Specifically, when the last sent packet is
-    acknowledged, the sender waits a short period of time to allow for
-    reordering and then marks any unacknowledged packets as lost. This mechanism
+  * When at least one packet that was sent a threshold number of packets

I agree it's a bit hard to read.  Packet number skipping doesn't matter, because the sender knows it skipped packets.  It does introduce extra work in that case, but it's easily solvable.

>  
-  * Instead of a packet threshold to tolerate reordering, a QUIC sender may use
-    a time threshold. This allows for senders to be tolerant of short periods of
-    significant reordering. In this mechanism, a QUIC sender marks a packet as
-    lost when a packet larger than it is acknowledged and a threshold amount of
-    time has passed since the packet was sent.
+The above mechanisms use a packet threshold to tolerate
+reordering. Alternatively, a QUIC sender may use a time threshold. This allows

I tend to agree.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/536#discussion_r117386165