IETF Logo Mail Archive

Re: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)

MikkelFJ <notifications@github.com> Tue, 16 April 2019 04:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 88179120457 for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 21:53:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.384
X-Spam-Level:
X-Spam-Status: No, score=-6.384 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3Orj1MfoU6Gv for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 21:53:07 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D565112035D for <quic-issues@ietf.org>; Mon, 15 Apr 2019 21:53:06 -0700 (PDT)
Date: Mon, 15 Apr 2019 21:53:05 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555390385; bh=LVH7F8OQa0STPG9vANQt75QE+nxP/HRzxg/7K27prTk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XjtL8Ss3JilqnOs4x/CD98nEr71Yb3gvyGiuxZDUFct/EzhWxHKYIWYDS8t5J1/S4 KiCLiSrUJBD1E3xVFl/BmdxCnUbI7XmumM7anB4ggFzv37IgZoMUUJERIL5nCYoV2L G+PM7VCV8N19nwJU5zthteCyaRNiscURFSRLjOZg=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba94c1f772d342ef6ba69d7a1b4ac06f660fc7ab292cebac2923192a169ce19d467b3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2621/c483510369@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2621@github.com>
References: <quicwg/base-drafts/pull/2621@github.com>
Subject: Re: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb55fb1ad075_59633fbcf16d45b456761f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/44vxI5UNV4sOJz57Aw6mb-nKF68>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2019 04:53:09 -0000

I’m not following closely but in C signed integers are undefined for operations modulo their size. I.e. overflow leads to random results, and this is not theoretical - optimizers take advantage.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2621#issuecomment-483510369

v2.23.0 | Report a Bug | By Email