Re: [quicwg/base-drafts] Replace HTTP_MALFORMED_FRAME error code (#2662)

Lucas Pardue <notifications@github.com> Mon, 01 July 2019 13:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 16CA012024D for <quic-issues@ietfa.amsl.com>; Mon, 1 Jul 2019 06:42:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id axXky3pVkA5S for <quic-issues@ietfa.amsl.com>; Mon, 1 Jul 2019 06:42:31 -0700 (PDT)
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F1D7712024E for <quic-issues@ietf.org>; Mon, 1 Jul 2019 06:42:30 -0700 (PDT)
Date: Mon, 01 Jul 2019 06:42:30 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561988550; bh=8F4B5ptDuip9Tqy5TqNnOVqZdgRi64A71R9wq54T+yU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=i1c5KAK7kO/nvKIHXnCOPsOZmoNc7Z4CRfwoL2IDWMljoL+bteJKmd3saqAuPpuFE pfmTjLP/DI3OmMSWxmvGmE9YPLIqVdWEDEcr9KTphT0pkGra6mqgMeJhwo7oDcLgrn rTsYlIVfSZqIBOHevALnpYvP/Wd+gCjL9STBILbI=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3NIVVHXU77D5GPO6V3E5AENEVBNHHBULDWIQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2662/c507269811@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2662@github.com>
References: <quicwg/base-drafts/pull/2662@github.com>
Subject: Re: [quicwg/base-drafts] Replace HTTP_MALFORMED_FRAME error code (#2662)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d1a0dc637861_27a13f84652cd96c9985f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/46QawkAslS0LvHze16TS4DOPEew>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jul 2019 13:42:46 -0000

I've rebased this PR to incorporate all of the error code rationalization changes that were merged to master. This PR does a few things:

* Resurrects H2's FRAME_SIZE_ERROR but broadens it to include frame layout errors - name is HTTP_FRAME_ERROR
* Introduces a new error code HTTP_INVALID_PRIORITY that captures cases where a frame with valid wire layout attempts to create a prioritiation relationship (see additional point below)
* Replaces occurrences of HTTP_MALFORMED_FRAME with: HTTP_ID_ERROR, HTTP_FRAME_ERROR, HTTP_INVALID_PRIORITY.
*  Reshuffles all of the error codes. In doing so, I tried to align the code space with H2 and avoid there being any gaps.

I'm not 100% convinced we need a HTTP_INVALID_PRIORITY code. I'm open to simply using HTTP_FRAME_ERROR.

HTTP_SETTINGS_ERROR and HTTP_MISSING_SETTINGS are candidates to be consolidated (either together, or into another code). This is dependent on discussion in (and related to) https://github.com/quicwg/base-drafts/issues/2783. I suggest we solve that in a different PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2662#issuecomment-507269811