Re: [quicwg/base-drafts] handle reordered NEW_CONNECTION_ID frames (#3202)

Mike Bishop <notifications@github.com> Thu, 07 November 2019 19:35 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 215F71209E2 for <quic-issues@ietfa.amsl.com>; Thu, 7 Nov 2019 11:35:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wC6cxK4JJS4P for <quic-issues@ietfa.amsl.com>; Thu, 7 Nov 2019 11:35:23 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 30F611209BB for <quic-issues@ietf.org>; Thu, 7 Nov 2019 11:35:23 -0800 (PST)
Received: from github-lowworker-9bcb4a1.ac4-iad.github.net (github-lowworker-9bcb4a1.ac4-iad.github.net [10.52.25.84]) by smtp.github.com (Postfix) with ESMTP id 804EC661DCB for <quic-issues@ietf.org>; Thu, 7 Nov 2019 11:35:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573155322; bh=K0mBEUSrb1u9mwWMqbNc/UNdk8Cl7ybe26DPbCYtTLc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=OAmizpNqJezL7DKBHfuZE68YmRp78ZFBmUfqMKYhjmfshjAzt9LrrfSoNWTOLLNkg IHNiWoNvvoODQHCseoR+YDY3LP8SloVAcPBisO1+jrI+yhutmToNPxDieLs2gjA6oZ RmYpo1IdT1akTf9UEA+CtwU5VbJ/5jbjaCYdoRqU=
Date: Thu, 07 Nov 2019 11:35:22 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK54Q7CG7T2NSLYOL3V32GSHVEVBNHHB532OGU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3202/c551230648@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3202@github.com>
References: <quicwg/base-drafts/pull/3202@github.com>
Subject: Re: [quicwg/base-drafts] handle reordered NEW_CONNECTION_ID frames (#3202)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc471fa6e651_5ab13fb411ccd9681343c"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/474zNEsZiVVxyWHKXkESn_LORA8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Nov 2019 19:35:27 -0000

The situation is a bit perverse to begin with.  RPT isn't permitted to be >= the sequence number of the new CID, which means they've already issued you 10k CIDs for that situation to be real.

If the peer revokes a block of 10k CIDs via RPT, they're expecting to get 10k RCID frames, minus any that might already have been sent.  Yes, that means they might then issue a similarly large block of CIDs, which you will then forget silently and the insanity will play itself out again the next time they revoke a large batch.  This glut is best managed by using the existing TP and not permitting the peer to send you an unlimited number of CIDs.

This also argues, perhaps, for making the default something more sensible than "infinite" in #3197.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3202#issuecomment-551230648