Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806)

Martin Thomson <> Wed, 03 July 2019 04:58 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id D1576120182 for <>; Tue, 2 Jul 2019 21:58:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id W0COIqojX1Ye for <>; Tue, 2 Jul 2019 21:58:36 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id B5E71120111 for <>; Tue, 2 Jul 2019 21:58:35 -0700 (PDT)
Date: Tue, 02 Jul 2019 21:58:34 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1562129914; bh=9hzhnmnmdK1ctJ+MTr8TEKrpPRdN6CKZOkllSjuVQzg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1FKUiIYoYM0tMNM1vrP8nlH2A2ju/KYkueUQRQmGqgGT2kWxKkVrEfVqiOA+EM9EX 5gcvNcUE+YT2KzdHEAftJrX2W2YLl3aZE3ZoM1l4Grp1SZCjmGYsVs+Jm9BlJayZ6p LeMaaQEOdLq3n1RSDC010iKFsj5tGQ4NZm1CaU2I=
From: Martin Thomson <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2806/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d1c35faa0e72_6b1b3ffd574cd968472e3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 03 Jul 2019 04:58:38 -0000

martinthomson commented on this pull request.

 A sender computes its PTO timer every time an ack-eliciting packet is sent. A
 sender might choose to optimize this by setting the timer fewer times if it
 knows that more ack-eliciting packets will be sent within a short period of
+The probe timer is not set if the time threshold {{time-threshold}} loss
+detection timer is set.  The time threshold loss detection timer is expected
+to both expire earlier than the PTO and be less likely to spuriously retransmit
+data. The Initial and Handshake packet number spaces will typically contain a
+small number of packets, so losses are less likely to be detected using
+packet-threshold loss detection.
+## Handshakes and new paths

## Handshakes and New Paths

> @@ -1283,7 +1237,7 @@ OnLossDetectionTimeout():
-    crypto_count++
+    pto_count++

The alignment looks off here.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: