Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.



>  
 A sender computes its PTO timer every time an ack-eliciting packet is sent. A
 sender might choose to optimize this by setting the timer fewer times if it
 knows that more ack-eliciting packets will be sent within a short period of
 time.
 
+The probe timer is not set if the time threshold {{time-threshold}} loss
+detection timer is set.  The time threshold loss detection timer is expected
+to both expire earlier than the PTO and be less likely to spuriously retransmit
+data. The Initial and Handshake packet number spaces will typically contain a
+small number of packets, so losses are less likely to be detected using
+packet-threshold loss detection.
+
+## Handshakes and new paths

```suggestion
## Handshakes and New Paths
```

> @@ -1283,7 +1237,7 @@ OnLossDetectionTimeout():
        SendOneHandshakePacket()
      else:
        SendOnePaddedInitialPacket()
-    crypto_count++
+    pto_count++

```suggestion
     pto_count++
```
The alignment looks off here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2806#pullrequestreview-257259977