Re: [quicwg/base-drafts] Improve KEY_PHASE description (#43)

Martin Thomson <notifications@github.com> Wed, 30 November 2016 01:35 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 144C712941A for <quic-issues@ietfa.amsl.com>; Tue, 29 Nov 2016 17:35:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.797
X-Spam-Level:
X-Spam-Status: No, score=-5.797 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, RP_MATCHES_RCVD=-1.497, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wG9Xj90xed4N for <quic-issues@ietfa.amsl.com>; Tue, 29 Nov 2016 17:35:27 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D1DA129D20 for <quic-issues@ietf.org>; Tue, 29 Nov 2016 17:35:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=github.com; h=from:reply-to:to:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=c6yx6HZLNJNyjfxXlZ8ygQmIW5M=; b=pIyRcHC5qIG0nfn+ 72fDuDVwKSIRpxp2BlhYuqq8SIKouaViow3yBJCUtlayWiA+IDRhdAp6u5IYj/uv jjzDu0o2eZn8GUDN3gdQ7gk2oy5x7KSh3qBr04BIHFo8Sdlzhd/pYy6SWhCddE7k 9nNcXcmnEbpF8ROf4/QufXT8gfA=
Received: by filter0937p1mdw1.sendgrid.net with SMTP id filter0937p1mdw1-23269-583E2CDE-33 2016-11-30 01:35:26.614384383 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id oT40YgDLSly_Hii9PDsLpw for <quic-issues@ietf.org>; Wed, 30 Nov 2016 01:35:26.726 +0000 (UTC)
Date: Tue, 29 Nov 2016 17:35:26 -0800
From: Martin Thomson <notifications@github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/43/review/10677331@github.com>
In-Reply-To: <quicwg/base-drafts/pull/43@github.com>
References: <quicwg/base-drafts/pull/43@github.com>
Subject: Re: [quicwg/base-drafts] Improve KEY_PHASE description (#43)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_583e2cde9cdd7_18e13ff080f7b13c258677"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0SLeCmzUpntePvCZfIsSHFfpe9PeNkReHiYY Z8XA+9q9C6p3ZpF7IaPUacHPiDSqOARlGpHYnQxXOSTJu1HwVOFkFm5g3Wp4Kt6IxCKuM2j7AUFH2A oKbPBcn0kIQ/R5kpXzaVlZHxT0UhPUs6Bk8p0jOkXpEEnZBrkG2seHGhtWm3FvDFvNPaqwfU9uO4Dd 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4GOBrOyaCDl1b2d4kxYMrsqNKdM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.17
Reply-To: quicwg/base-drafts <reply+0166e4ab9c1cc30399a137999ceea38df1b1e64bf8db25ed92cf000000011455eede92a169ce0b74c956@reply.github.com>
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Nov 2016 01:35:29 -0000

martinthomson commented on this pull request.



> +decrypt these packets, which will be unsuccessful.  Though a server that has
+1-RTT keys can safely discard any unprotected handshake messages from the
+client, an unprotected ACK frame could indicate that the server needs to
+retransmit its own handshake messages.  ACK frames therefore cannot be
+discarded.
+
+Until the server has received a positive acknowledgment for all of its
+unprotected handshake messages, either in the form of an explicit acknowledgment
+or implicitly through the use of 1-RTT keys, it MUST NOT discard packets with a
+KEY_PHASE of 0 if they cannot be decrypted successfully.  If these packets are
+unprotected and contain ACK frames, those ACK frames MUST be recovered and used
+to determine whether to retransmit TLS handshake messages.
+
+TBD:
+
+: We could observe/require that all unprotected packets are marked with a

It doesn't remove the asymmetry, but yeah, it's probably worth doing still.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/43