[quicwg/base-drafts] Fix PTO calculation in pseudo-code (#2489)

Alessandro Ghedini <notifications@github.com> Thu, 28 February 2019 11:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 551DB128BCC for <quic-issues@ietfa.amsl.com>; Thu, 28 Feb 2019 03:19:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ai4W0tYqvM2W for <quic-issues@ietfa.amsl.com>; Thu, 28 Feb 2019 03:19:22 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 323BC130E7E for <quic-issues@ietf.org>; Thu, 28 Feb 2019 03:19:21 -0800 (PST)
Date: Thu, 28 Feb 2019 03:19:20 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1551352760; bh=5rrmuKWspcnFgvhOdzsqawCNvVHBhGkwUOLq+6StPb0=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=X/J0MaMH0FYr6kQIOUUcS56CuZc86TMSiFN+xcMOWQwd4mt7kf5irHrNqnAVAjEH0 n9dPuJFNxsw52d9EarBhgRqImU7pLTNrP0qWTCwa2J3lcvEdJJsD+j/cyEn/5TkzXu hOCOSBGJPGuPB54hIJXjDMr3mwoGZg972dNbqmm0=
From: Alessandro Ghedini <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab213f9f90d9f053db1cfe39fe5a7c8dbc06992e7892cf00000001188f85b892a169ce18c52434@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2489@github.com>
Subject: [quicwg/base-drafts] Fix PTO calculation in pseudo-code (#2489)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c77c3b8bf774_70be3f9e076d45b882448"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ghedo
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4JKxelWcI1JvXPtZnb6OsHAVeZA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Feb 2019 11:19:24 -0000

Maybe I'm missing something, but it seems #2480 forgot to update the pseudo-code where PTO is used.

Also, should the PTO calculated in `InPersistentCongestion()` also use `kGranularity`?
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/2489

-- Commit Summary --

  * Fix PTO calculation in pseudo-code

-- File Changes --

    M draft-ietf-quic-recovery.md (3)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/2489.patch
https://github.com/quicwg/base-drafts/pull/2489.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2489