Re: [quicwg/base-drafts] ACK Delay interactions with RTT calculation (#2137)
janaiyengar <notifications@github.com> Thu, 13 December 2018 06:18 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C88612875B for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 22:18:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7igSDj99M0qQ for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 22:18:14 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 69156126CC7 for <quic-issues@ietf.org>; Wed, 12 Dec 2018 22:18:14 -0800 (PST)
Date: Wed, 12 Dec 2018 22:18:13 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544681893; bh=mkea557rpJb+AFkdukzPxRrkgbaNUW9jPT9pEFDBWhw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=qYV3chV4fWQoA8kufsqyQ5e+Lq7Knfm6jqDD7vhESR3U3jFIrytEo2D3O8q0mFf/X tthnBBiXZBoYAGkU2486JRpNzYyQFSsXr12ncHOi6wu23WIy5ANIPiW19HsSdpFJBq 20ZWeLa17eNCW9/Sz4vxT9/BEO//p/WVdz3Lx4B0=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abff57f669c934061459030bfd548d21c6352770c492cf000000011829bba592a169ce1746f27a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2137/446855221@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2137@github.com>
References: <quicwg/base-drafts/issues/2137@github.com>
Subject: Re: [quicwg/base-drafts] ACK Delay interactions with RTT calculation (#2137)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c11f9a563dda_79123fdc73cd45bc4070c8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4MmhX4P8_HF6EDRFfANYWcTNKrE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 06:18:17 -0000
On your first point, this was an outcome of #2060. Yes, it is a min, as the pseudocode says. For context, when #1438 was being discussed, two things were true that aren't anymore: (i) non-ack-eliciting packets were being used for the RTT computation, and (ii) we were using max(observed ack_delays) as the max_ack_delay. We've since replaced that computation with the peer's explicitly stated max_ack_delay in our RTO computations. So if you do get inflated ack delays, that's going to be because acks were being lost or the receiver took too long to send an ack. In either case, we want to capture the resulting increase somewhere, since the RTO should incorporate such potential delays. In #2060, we decided to let the smoothed_RTT EWMA estimator handle it. If it's rare, it shouldn't move the EWMA by much. If it's not rare, then the EWMA will capture it, and we will appropriately end up with a larger RTO. On your second point, yes, ack delay of 0 is what is meant there. Should there be more text? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/2137#issuecomment-446855221
- [quicwg/base-drafts] ACK Delay interactions with … Martin Thomson
- Re: [quicwg/base-drafts] ACK Delay interactions w… janaiyengar
- Re: [quicwg/base-drafts] ACK Delay interactions w… Martin Thomson
- Re: [quicwg/base-drafts] ACK Delay interactions w… janaiyengar
- Re: [quicwg/base-drafts] ACK Delay interactions w… ianswett