Re: [quicwg/base-drafts] Update PTO pseudocode to better match text (#3461)

Martin Thomson <notifications@github.com> Sun, 15 March 2020 21:34 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 007E83A1CAE for <quic-issues@ietfa.amsl.com>; Sun, 15 Mar 2020 14:34:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pSDr16EtbN7P for <quic-issues@ietfa.amsl.com>; Sun, 15 Mar 2020 14:34:57 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B1A3C3A1CAA for <quic-issues@ietf.org>; Sun, 15 Mar 2020 14:34:57 -0700 (PDT)
Received: from github-lowworker-fa7043e.ash1-iad.github.net (github-lowworker-fa7043e.ash1-iad.github.net [10.56.109.45]) by smtp.github.com (Postfix) with ESMTP id CAB30C602D6 for <quic-issues@ietf.org>; Sun, 15 Mar 2020 14:34:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584308096; bh=/J/qO5rBTeUn1uwJSuamQuReTj7QQJtXkHnueaWnGyQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=qdlB7grKQgSVt+mzOBnpz6XnPyluEFTedK3XkDEj6l86spik2MK4OzTfcOs6JTSOh /KbqbA/pje3D+uEL3xybytEtw65zInUbl4121djY4eQ4/2QwqBqSiABOKv1wu3Nasx PVxFJJw1nKCkw/3haWaIex+kVYM5pKV9mlXg0FPo=
Date: Sun, 15 Mar 2020 14:34:56 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7ZS5VYZNRL4KQVOR54PKAIBEVBNHHCDOLCFM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3461/review/374835865@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3461@github.com>
References: <quicwg/base-drafts/pull/3461@github.com>
Subject: Re: [quicwg/base-drafts] Update PTO pseudocode to better match text (#3461)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e6e9f80bb491_74d3fc5a66cd96814643d"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4NI-UP_-7oc52gD0ILOdKQcShPM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Mar 2020 21:34:59 -0000

martinthomson approved this pull request.



> +    // There is nothing to detect lost and the server
+    // is not blocked by the anti-amplification limit.

This comment is a little strange.

The point here is to catch the case where there is nothing to send, with the exception that the client might need to keep the server primed in case it is blocked on its anti-amplification limit.

As we've already dispensed with the anti-amplification limit at the server, I think that this needs to concentrate on the client instead.

```suggestion
    // There is nothing to detect lost, so set no timer.
    // However, the client still sets the timer if the server
    // might be blocked by the anti-amplification limit.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3461#pullrequestreview-374835865