Re: [quicwg/base-drafts] Change on idle behaviour (#2553)

Martin Thomson <notifications@github.com> Tue, 10 September 2019 22:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 12EBB12006B for <quic-issues@ietfa.amsl.com>; Tue, 10 Sep 2019 15:42:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NsHaYWPCldHP for <quic-issues@ietfa.amsl.com>; Tue, 10 Sep 2019 15:42:04 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 276EF120019 for <quic-issues@ietf.org>; Tue, 10 Sep 2019 15:42:04 -0700 (PDT)
Date: Tue, 10 Sep 2019 15:42:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568155323; bh=3QbHK01CJFtZpgM+9DhmYYF7J88uHLtb7KHcpoxJkRk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=f9wSTa0z1iwCevsKwyqxLbjPuAKKCecg9W6eOGuDZVKOzfFIX+cduRuD48voJGBer kSVg89yTun6Dh8xZc/gwURZ5ozh6L7G58UwmS1HO/0fHT5FLbD9J9+VUE26wnR/7uH gc1u8IAYDMy6p9l9wYH/YV+UWtQV6pafG5B5wJFg=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2A2SNSJOZNNWTJCJV3QVFSVEVBNHHBSWPA2E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2553/review/286474082@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2553@github.com>
References: <quicwg/base-drafts/pull/2553@github.com>
Subject: Re: [quicwg/base-drafts] Change on idle behaviour (#2553)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d7826bae8ea7_5a23f83f82cd95c3801f5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4RJuBAy0b53ebVAwy3LNyGunuBo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Sep 2019 22:42:06 -0000

martinthomson commented on this pull request.

This seems good, but it won't apply.

> @@ -724,13 +724,11 @@ in Linux (3.11 onwards).
 A sender becomes idle if it ceases to send data and has no bytes in flight.  A
 sender's congestion window MUST NOT increase while it is idle.
 
-When sending data after becoming idle, a sender MUST reset its congestion window
-to the initial congestion window (see Section 4.1 of {{?RFC5681}}), unless it
-paces the sending of packets. A sender MAY retain its congestion window if it
-paces the sending of any packets in excess of the initial congestion window.
-
-A sender MAY implement alternate mechanisms to update its congestion window
-after idle periods, such as those proposed for TCP in {{?RFC7661}}.
+When sending data after becoming idle and a sender does not pace the sending
+of packets, it MUST reset its congestion window to the initial congestion
+window (see Section 4.1 of {{?RFC5681}}). If packet sending is paced, a sender
+MAY implement alternate mechanisms to update its congestion window after idle

```suggestion
MAY implement alternative mechanisms to update its congestion window after idle
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2553#pullrequestreview-286474082