Re: [quicwg/base-drafts] Clarify and split the "malformed" definition (#3352)

Lucas Pardue <notifications@github.com> Fri, 17 January 2020 00:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 882D412008C for <quic-issues@ietfa.amsl.com>; Thu, 16 Jan 2020 16:29:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3
X-Spam-Level:
X-Spam-Status: No, score=-3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HpF8rCGRpiAM for <quic-issues@ietfa.amsl.com>; Thu, 16 Jan 2020 16:29:30 -0800 (PST)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7FD9B120059 for <quic-issues@ietf.org>; Thu, 16 Jan 2020 16:29:30 -0800 (PST)
Received: from github-lowworker-edec459.ac4-iad.github.net (github-lowworker-edec459.ac4-iad.github.net [10.52.18.32]) by smtp.github.com (Postfix) with ESMTP id 4169E2800A2 for <quic-issues@ietf.org>; Thu, 16 Jan 2020 16:29:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579220969; bh=avAwJO8bOy0PxvYUR49M5iXKm21aJWBb+sCJq+UfR1M=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1xUzc4g+43o9sYHvOr+33sdQjl/LZwUeVwV4UYbpyhvdlme+W1D4nogIjZPflpG6m 6LXTSXrpbqpp7aU29HyL5XzvIyhK0I8EP8wMPxj0Dw1skhVGGBW/m5NnsoJ4ZwWAYr RQNasnAaQzzWq7gzY8/BJHCvVOtsia9cO5RKy5Wc=
Date: Thu, 16 Jan 2020 16:29:29 -0800
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6EZRERIW3527YJMRF4FYZGTEVBNHHCBV7VNU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3352/review/344293974@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3352@github.com>
References: <quicwg/base-drafts/pull/3352@github.com>
Subject: Re: [quicwg/base-drafts] Clarify and split the "malformed" definition (#3352)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e20ffe9311fc_5f403fce36acd96c7469e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4SnXY3S7X1fi9S_cAVWHrcJ8Kns>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2020 00:29:32 -0000

LPardue commented on this pull request.

I think this is a good addition. I did however find some small room for improvement :99:

> @@ -410,10 +417,10 @@ considered invalid.
 
 An HTTP request/response exchange fully consumes a bidirectional QUIC stream.

I guess while we are changing so much text we could make it explicity and say

"An HTTP request/response exchange fully consumes a client-initiated bidirectional QUIC stream."

> @@ -450,15 +457,103 @@ field names MUST be converted to lowercase prior to their encoding.  A request
 or response containing uppercase header field names MUST be treated as
 malformed ({{malformed}}).
 
+Like HTTP/2, HTTP/3 does not use the Connection header field to indicate
+connection-specific header fields; in this protocol, connection- specific

```suggestion
connection-specific header fields; in this protocol, connection-specific
``` or is the space intended?

> @@ -520,9 +617,9 @@ permitted (e.g., idempotent actions like GET, PUT, or DELETE).
 ### Malformed Requests and Responses {#malformed}
 
 A malformed request or response is one that is an otherwise valid sequence of
-frames but is invalid due to the presence of extraneous frames, prohibited
-header fields, the absence of mandatory header fields, or the inclusion of
-uppercase header field names.
+frames but is invalid due to the presence of prohibited header fields, the
+absence of mandatory header fields, an invalid sequence of HTTP messages, or the
+inclusion of uppercase header field names.

You don't mention pseudo-header fields in this paragraph but I think it would help to do so (because earlier it says `Pseudo-header fields are not HTTP header fields.`).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3352#pullrequestreview-344293974