Re: [quicwg/base-drafts] QPACK: make TSS=0 a connection error (#1762)

Dmitri Tikhonov <notifications@github.com> Tue, 18 September 2018 20:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4492D130E47 for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 13:41:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6OTfv5U2Nuku for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 13:41:03 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DF50A129AB8 for <quic-issues@ietf.org>; Tue, 18 Sep 2018 13:41:02 -0700 (PDT)
Date: Tue, 18 Sep 2018 13:41:01 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537303261; bh=3I+bwst9DdxX37jRHjPntBUb6WYni9yCLWEQH+8Ybvo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=W/g269pqpa0FaZihj7T60bh8byTO86x3RwtbxGiIztikC2yNJOYUEKWoDNS+OFgcq psndgzctdGKZipAeHRziH+4UOHsJdUvEy3z+ws2q69po4dOAZGJ4CCmi/mEs8beRr3 1+e70S9NLidcAHPX8DnlaQTj0EgBGerxXpJ3yFZA=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab92506909ade7316cd00497361664344fd286438292cf0000000117b924dd92a169ce158602f3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1762/review/156559201@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1762@github.com>
References: <quicwg/base-drafts/pull/1762@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: make TSS=0 a connection error (#1762)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba162ddde1e1_9e83fa1586d45b46659e5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4TDpPRh2_slyo0gTZNRBNXhJEPE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 20:41:05 -0000

dtikhonov requested changes on this pull request.



> @@ -587,9 +587,10 @@ entries might cause a stream to become blocked, as described in
 ~~~~~~~~~~
 {:#fig-size-sync title="Table State Synchronize"}
 
-An encoder that receives an Insert Count that is greater than the number of
-dynamic table entries beyond the current Largest Known Received entry MUST treat
-this as a connection error of type `HTTP_QPACK_DECODER_STREAM_ERROR`.
+An encoder that receives an Insert Count equal to zero, or that is greater than

I don't like the "that" in "or that:" does it refer to the insert count or to the encoder?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1762#pullrequestreview-156559201