IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add Definitions (#1557)

ianswett <notifications@github.com> Wed, 01 August 2018 23:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA469130E40 for <quic-issues@ietfa.amsl.com>; Wed, 1 Aug 2018 16:40:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZT1fozXKxvlJ for <quic-issues@ietfa.amsl.com>; Wed, 1 Aug 2018 16:40:29 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E6D93130DC3 for <quic-issues@ietf.org>; Wed, 1 Aug 2018 16:40:28 -0700 (PDT)
Date: Wed, 01 Aug 2018 16:40:28 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533166828; bh=uui/UY6hAaDB7DZ8aJL5AJh/gcYQsK27yJXeEnA9BVM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dSrOS3ZjD/CsGM0gw1TNJptIOjPi2IQBVYB/o7IVNce203f8U2l/CKuRn+Q9yjM6D PW3SMnRznqGnOD1M+TD32KlAIM5Pbkrljv0wyovMNmB7cJHdlLUwX7HlEw+33uWv8N LLUYYfCThp7Cqpx0YM9Xy+ZEge5I/SBVVVSb4nzA=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3d52222f3d3cac9b249e980bd726ff46cc4f6c6692cf00000001177a06ec92a169ce1456e92b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1557/review/142602097@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1557@github.com>
References: <quicwg/base-drafts/pull/1557@github.com>
Subject: Re: [quicwg/base-drafts] Add Definitions (#1557)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b6244ec3a4df_b5523f8b168be620935e0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4Taa48iYXf8bdXzXQZRAlCzwbY0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2018 23:40:31 -0000

ianswett commented on this pull request.



>  
 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD",
 "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this
 document are to be interpreted as described in BCP 14 {{!RFC2119}} {{!RFC8174}}
 when, and only when, they appear in all capitals, as shown here.
 
+Definitions of terms that are used in this document:
+
+ACK frames:
+
+: ACK frames refer to both ACK and ACK_ECN frames in this
+  document.
+
+ACK-only:
+
+: Any packet containing only an ACK or ACK_ECN frame.
+
+In-flight:
+
+: Packets are considered in-flight when they have been sent
+  and neither acknowledged or declared lost, and they are not

Thanks Mike, I fixed it in master

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1557#discussion_r207064544

v2.31.3 | Report a Bug | By Email | System Status