Re: [quicwg/base-drafts] eliminate the difference between when having no RTT sample and having one (#3525)

Jana Iyengar <notifications@github.com> Tue, 17 March 2020 22:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 22BDF3A0915 for <quic-issues@ietfa.amsl.com>; Tue, 17 Mar 2020 15:17:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.473
X-Spam-Level:
X-Spam-Status: No, score=-1.473 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 153uVsF43ubP for <quic-issues@ietfa.amsl.com>; Tue, 17 Mar 2020 15:17:26 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F062D3A0902 for <quic-issues@ietf.org>; Tue, 17 Mar 2020 15:17:25 -0700 (PDT)
Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id 3F3EBC60802 for <quic-issues@ietf.org>; Tue, 17 Mar 2020 15:17:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584483445; bh=Vx8nugw5yG6tCHWJE1w6QIrtDU3qg4MIm4ud21vzFpw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XxjRDcU9xAp6IxzSnMBwx+COE6eGX+RyCIzihKcMzZywg6y+WHOQ2kMKSVpUvv5fH PSQurG5/M7EmOzBZD96RFe8JYfKHPckkCcxrzA1ebtXp8sEzRBX8a72T2ouP4JSwif qoLN8wDOQ0HC1TQirIAdPHpwL7F5Nj1Zylw+FF/Y=
Date: Tue, 17 Mar 2020 15:17:25 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2NB23WE5PZ4GSKE5F4PUWXLEVBNHHCFKOIVY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3525/review/376442220@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3525@github.com>
References: <quicwg/base-drafts/pull/3525@github.com>
Subject: Re: [quicwg/base-drafts] eliminate the difference between when having no RTT sample and having one (#3525)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e714c7530a66_74af3fd81c2cd95c39950"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4UpLZk3nYc7rAXsOLB8mvUSIA9g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Mar 2020 22:17:55 -0000

janaiyengar approved this pull request.

Thank you, @kazuho, this is a good fix. This also fixes the case where the 2 x initialRtt is smaller than granularity.

>  ~~~
 
+where rtt_sample is the initial RTT.
+
+On the first RTT sample for the network path, smoothed_rtt and rttvar are set to
+the values using the formula above, using that first RTT sample as rtt_sample.
+This ensures a measurement erases the history of any persisted or default value.

```suggestion
This ensures that the first measurement erases the history of any persisted or default value.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3525#pullrequestreview-376442220