[quicwg/base-drafts] Alternative largest reference algorithm (#1904)

Martin Thomson <notifications@github.com> Wed, 24 October 2018 22:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E1F2E130E1E for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 15:50:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0PcGvsAt82BH for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 15:50:15 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C30AA130DD7 for <quic-issues@ietf.org>; Wed, 24 Oct 2018 15:50:13 -0700 (PDT)
Date: Wed, 24 Oct 2018 15:50:12 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540421412; bh=AhGgnYTSjSrlsMkIVK4+uFFNHfIbHQE/+4MRftGRtHs=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=FhI0pPHNXPbE85utgQhVUUqJ7DvxYXdTImCHAYz0nzTP3SU9JtnwMa8p2urbE2umO Fj9pGtAcZ1+Nlp7bD70yokAkRC6FN6cftN2jxfLXokgIkzAKGK9sWNbPlA8+jInf78 YGayWm+FaMd/+cjDpFTQyCFxpFSQ4whtxwgRihNE=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8047969da72da525f99118fbc7a2cac73dd5644792cf0000000117e8b92492a169ce1646529e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1904@github.com>
Subject: [quicwg/base-drafts] Alternative largest reference algorithm (#1904)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd0f7247e04d_57883fc99ced45b810923d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4VFvkPfNsbgL79LJmy44IWSqElg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 22:50:20 -0000

@afrind suggested that the shorter algorithm I used for largest reference decoding might be better than the one in the doc.

This is the relevant piece of the python script used to test this (which we might also consider putting in the repo).

``` python
max_entries = int(math.floor(table_size / 32))
full_range = 2 * max_entries
if wire_lr == 0:
    lr = 0
else:
    max_value = decoder_base + max_entries
    rounded = math.floor(max_value / full_range) * full_range
    lr = rounded + wire_lr - 1
    if lr > max_value and lr >= full_range:
        lr -= full_range
```

Here until the QPACK reorg finishes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1904