IETF Logo Mail Archive

Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)

Kazuho Oku <notifications@github.com> Tue, 18 September 2018 12:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C3FC1130E02 for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 05:27:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dzTr5c64dZ7h for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 05:27:34 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4C5AD130DBE for <quic-issues@ietf.org>; Tue, 18 Sep 2018 05:27:34 -0700 (PDT)
Date: Tue, 18 Sep 2018 05:27:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537273653; bh=J3VpWzxtpqeiYaXD4u8x7774RMt5E7xqJkAwEKXzgtE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eiJQbfgM49281mMj/i4w+BKH2B/6S2IKygd+CshpqVltXdk1PYsU2RBtoy3sThXTt AJi4UUdonxJfNo442D0qu2qJJ4n9XoHr1i1l1Fj5xaZc67CjtAbgjFAxCkYCUS10FD g7+BJOm6tYHyzQgkqUdnQOHmPkSWycvsnHFUkBsU=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2abba10191108cdbf3cfb9f41316d8ace978c5c992cf0000000117b8b13492a169ce1586350b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1763/c422371719@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1763@github.com>
References: <quicwg/base-drafts/pull/1763@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba0ef34ed2a5_4c323f9e0b4d45c082480"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4bVBUeP81Rfy6Rq_qQ2-yrBFcls>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 12:27:36 -0000

Would it make sense to describe the table as a "ring buffer" rather than a FIFO buffer with index calculation using modulo?

I think doing so would simplify the text and help readers understand the design (OTOH the downside being that you might need to change more text; e.g. by renaming `largest_reference` to `base_index`).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1763#issuecomment-422371719

v2.30.2 | Report a Bug | By Email | System Status