Re: [quicwg/base-drafts] Define the use of generic TLS alerts (#3601)

Kazuho Oku <notifications@github.com> Tue, 28 April 2020 06:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BEFE3A0BAD for <quic-issues@ietfa.amsl.com>; Mon, 27 Apr 2020 23:17:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.099
X-Spam-Level:
X-Spam-Status: No, score=-3.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HgM22uJGCA-m for <quic-issues@ietfa.amsl.com>; Mon, 27 Apr 2020 23:17:26 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 940CD3A0BA1 for <quic-issues@ietf.org>; Mon, 27 Apr 2020 23:17:26 -0700 (PDT)
Received: from github-lowworker-943b171.ac4-iad.github.net (github-lowworker-943b171.ac4-iad.github.net [10.52.22.59]) by smtp.github.com (Postfix) with ESMTP id 0A4D78C0047 for <quic-issues@ietf.org>; Mon, 27 Apr 2020 23:17:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1588054645; bh=XJBwvJ/L01mrmwFQU3k/drvwT0Hv4V65VZGgrSvKYcQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SU7NzXc8TgPwLcAbXb+N8TDxazzsV7Gt8+WDWwLZgdW0/Xj3wbdmqFxwpYDCgsSdK pJlP1aRTwXdFvEXyNNcNKdStVMYfkIXDDoGAek1z0bckiSrgZss00vnEm79jKz3eoN xQZ3yISmKEgf6y2LlY0clJWPDYkSMIN6kmlHB0AQ=
Date: Mon, 27 Apr 2020 23:17:24 -0700
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4QPXDWTUHIH3VNNTN4WOVXJEVBNHHCIPNKJY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3601/review/401526081@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3601@github.com>
References: <quicwg/base-drafts/pull/3601@github.com>
Subject: Re: [quicwg/base-drafts] Define the use of generic TLS alerts (#3601)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ea7ca74eda95_2fa93f8a00acd964408171"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4wIJ-KcQSndc-X6elO9Ly-Dqihc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 06:17:29 -0000

@kazuho commented on this pull request.



> @@ -1567,12 +1573,13 @@ QUIC requires that the cryptographic handshake provide authenticated protocol
 negotiation.  TLS uses Application Layer Protocol Negotiation (ALPN)
 {{!ALPN=RFC7301}} to select an application protocol.  Unless another mechanism
 is used for agreeing on an application protocol, endpoints MUST use ALPN for
-this purpose.  When using ALPN, endpoints MUST immediately close a connection
-(see Section 10.3 in {{QUIC-TRANSPORT}}) if an application protocol is not
-negotiated with a no_application_protocol TLS alert (QUIC error code 0x178, see
-{{tls-errors}}).  While {{!ALPN}} only specifies that servers use this alert,
-QUIC clients MUST also use it to terminate a connection when ALPN negotiation
-fails.
+this purpose.
+
+When using ALPN, endpoints MUST immediately close a connection (see Section
+10.3 of {{QUIC-TRANSPORT}}) if an application protocol is not negotiated with a
+no_application_protocol TLS alert (QUIC error code 0x178, see {{tls-errors}}).
+While {{!ALPN}} only specifies that servers use this alert, QUIC clients MUST
+use error 0x178 to terminate a connection when ALPN negotiation fails.

Am I correct to read that this MUST requires a client that receives a no_application_protocol alert to respond with a no_application_protocol alert?

I am not sure if that aligns to what we have now. At the moment, the provisions that we have is that an endpoint that receives CONNECTION_CLOSE MAY respond with a CONNECTION_CLOSE, using NO_ERROR if appropriate (https://quicwg.org/base-drafts/draft-ietf-quic-transport.html#section-10.3-7).

Based on that, I think what we need here is MAY rather than MUST, and think that NO_ERROR is more appropriate (assuming that we do not have a principle of an endpoint that receives a CONNECTION_CLOSE frame carrying an error echo the error code it has received). Or it might make sense to just drop the last sentence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3601#pullrequestreview-401526081