Re: [quicwg/base-drafts] Include ack_delay when deciding with PN space to arm PTO for (#3666)

ianswett <notifications@github.com> Mon, 18 May 2020 17:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 925763A09BA for <quic-issues@ietfa.amsl.com>; Mon, 18 May 2020 10:45:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.501
X-Spam-Level:
X-Spam-Status: No, score=-0.501 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H6hQe9RQ_TM0 for <quic-issues@ietfa.amsl.com>; Mon, 18 May 2020 10:45:10 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ED2873A09B5 for <quic-issues@ietf.org>; Mon, 18 May 2020 10:45:09 -0700 (PDT)
Received: from github-lowworker-b2150d3.ash1-iad.github.net (github-lowworker-b2150d3.ash1-iad.github.net [10.56.113.12]) by smtp.github.com (Postfix) with ESMTP id 09A98C60619 for <quic-issues@ietf.org>; Mon, 18 May 2020 10:45:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589823909; bh=QoZf5fkv3awmRlN4SMjRUjFo67cYYxjRZLuzVQDizQM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=emzA0P0OnvI12rYnJf3V+M0FYoJs3stnHnYfVckcGku4pKECcZ8ptP5wOdNn6hZJd xBG1zmb3sBhagbxF1ph2BQf+rUoh4DV3x34tzxdi1ElHnEuq2YyXpP9l4dsc/hYxkr fmTS8rIQmZNoI0U2tQzAtfHo9oGB41mwp+fyYZaI=
Date: Mon, 18 May 2020 10:45:08 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZDGUMSZJGNPE7SNO54Z2VKJEVBNHHCJ5SAW4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3666/review/413808778@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3666@github.com>
References: <quicwg/base-drafts/pull/3666@github.com>
Subject: Re: [quicwg/base-drafts] Include ack_delay when deciding with PN space to arm PTO for (#3666)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ec2c9a4ef7ef_3e033f9e4d2cd96012691a"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4wsml4OEVCGWbZlakDzIGifkt9Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2020 17:45:12 -0000

@ianswett commented on this pull request.



> @@ -1270,7 +1273,7 @@ PeerCompletedAddressValidation():
        has received HANDSHAKE_DONE
 
 SetLossDetectionTimer():
-  earliest_loss_time, _ = GetEarliestTimeAndSpace(loss_time)
+  earliest_loss_time, _ = GetEarliestTimeAndSpace(loss_time, 0)
   if (earliest_loss_time != 0):
     // Time threshold loss detection.

loss_time tracks packets which may need to be declared lost.   The GetEarliestTimeAndSpace method operates on loss_times and time_of_last_sent_ack_eliciting_packet.  There were two methods, but they were doing the same thing.  This Issue/PR makes them sharing a method a bit more awkward, but it seems ok overall.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3666#discussion_r426793692