Date: Mon, 18 May 2020 10:45:08 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKZDGUMSZJGNPE7SNO54Z2VKJEVBNHHCJ5SAW4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3666/review/413808778@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3666@github.com>
References: <quicwg/base-drafts/pull/3666@github.com>
Subject: Re: [quicwg/base-drafts] Include ack_delay when deciding with PN
 space to arm PTO for (#3666)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5ec2c9a4ef7ef_3e033f9e4d2cd96012691a";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4wsml4OEVCGWbZlakDzIGifkt9Q>


----==_mimepart_5ec2c9a4ef7ef_3e033f9e4d2cd96012691a
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@ianswett commented on this pull request.



> @@ -1270,7 +1273,7 @@ PeerCompletedAddressValidation():
        has received HANDSHAKE_DONE
 
 SetLossDetectionTimer():
-  earliest_loss_time, _ = GetEarliestTimeAndSpace(loss_time)
+  earliest_loss_time, _ = GetEarliestTimeAndSpace(loss_time, 0)
   if (earliest_loss_time != 0):
     // Time threshold loss detection.

loss_time tracks packets which may need to be declared lost.   The GetEarliestTimeAndSpace method operates on loss_times and time_of_last_sent_ack_eliciting_packet.  There were two methods, but they were doing the same thing.  This Issue/PR makes them sharing a method a bit more awkward, but it seems ok overall.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3666#discussion_r426793692
----==_mimepart_5ec2c9a4ef7ef_3e033f9e4d2cd96012691a
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3666#discussion_r426793692">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1270,7 +1273,7 @@ PeerCompletedAddressValidation():
        has received HANDSHAKE_DONE
 
 SetLossDetectionTimer():
-  earliest_loss_time, _ = GetEarliestTimeAndSpace(loss_time)
+  earliest_loss_time, _ = GetEarliestTimeAndSpace(loss_time, 0)
   if (earliest_loss_time != 0):
     // Time threshold loss detection.
</pre>
<p>loss_time tracks packets which may need to be declared lost.   The GetEarliestTimeAndSpace method operates on loss_times and time_of_last_sent_ack_eliciting_packet.  There were two methods, but they were doing the same thing.  This Issue/PR makes them sharing a method a bit more awkward, but it seems ok overall.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3666#discussion_r426793692">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK32FQNPHLFN6WOR2KLRSFX2JANCNFSM4ND7HVNQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK5WGFZXT6T44LDCOKTRSFX2JA5CNFSM4ND7HVN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODCVDRCQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3666#discussion_r426793692",
"url": "https://github.com/quicwg/base-drafts/pull/3666#discussion_r426793692",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5ec2c9a4ef7ef_3e033f9e4d2cd96012691a--