IETF Logo Mail Archive

Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)

ianswett <notifications@github.com> Wed, 10 April 2019 19:13 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 26EFA120154 for <quic-issues@ietfa.amsl.com>; Wed, 10 Apr 2019 12:13:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.383
X-Spam-Level:
X-Spam-Status: No, score=-1.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bnXLZ2H-BxRI for <quic-issues@ietfa.amsl.com>; Wed, 10 Apr 2019 12:13:53 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B194C120103 for <quic-issues@ietf.org>; Wed, 10 Apr 2019 12:13:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Zbe6B+HFiwpzyKb0mHUu3bEfeRM=; b=MvyC7l0KAnvvranK tex32xodNExcgsDfQO4hJcbA0Ez53htqJ3j0PJlH4VOWaV48TEaq4m8SHuMsMFXQ pQjoLBAF17RXfgDx7+0optuqY+S2lpj48FISYFT0EFPF3sNfoPij4FDDtNSzWBdU DiLRBfj3subameZDnkY9RfdrZY8=
Received: by filter0831p1las1.sendgrid.net with SMTP id filter0831p1las1-24286-5CAE4071-1 2019-04-10 19:13:53.089445987 +0000 UTC m=+153273.141160698
Received: from github-lowworker-97d0962.cp1-iad.github.net (unknown [192.30.252.41]) by ismtpd0015p1iad1.sendgrid.net (SG) with ESMTP id z_FNxBSPSce_ltIIBBDpmg for <quic-issues@ietf.org>; Wed, 10 Apr 2019 19:13:52.916 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-97d0962.cp1-iad.github.net (Postfix) with ESMTP id DD027805C8 for <quic-issues@ietf.org>; Wed, 10 Apr 2019 12:13:52 -0700 (PDT)
Date: Wed, 10 Apr 2019 19:13:53 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7c8145ce78cb081a7e048ac380f3baabbb025f2892cebabb72f092a169ce199da23e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2590/review/225165599@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2590@github.com>
References: <quicwg/base-drafts/pull/2590@github.com>
Subject: Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cae4070db73c_7e2e3fce2f0d45c01130d2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2d9Jw6eOdQV0OZlvxBCclvhv0PTWlfyPeQ1R lQ9qSiFD5RLVJOP/6TwbKle8J7QgZPr4/a4zLmHN14FqDmP5CJ5xEHZx5C6zZ93yuP2mZ3b9zmZi8/ SvPsXCvsIzbtXs3rpQjvVQSPnubV/pwpvGJBpAozFPjQ9jijxf7QgBB0+g==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/50Sh0yYjZ1ifW-ahdq0pOEqHFFg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2019 19:13:55 -0000

ianswett commented on this pull request.



> @@ -1114,7 +1117,8 @@ SetLossDetectionTimer():
     loss_detection_timer.update(loss_time)
     return
 
-  if (crypto packets are in flight):
+  if (crypto packets are in flight &&
+      crypto data to send):

I removed this from here due to the other PR, but left it in below.  Feel free to suggest alternate phrasing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2590#discussion_r274116296

v2.14.0 | Report a Bug | By Email