Re: [quicwg/base-drafts] editorial: This sentence was hard to parse for me (recovery) (#3383)

mirjak <notifications@github.com> Wed, 22 January 2020 22:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6794F1201B7 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jan 2020 14:17:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C3K_FtaY62vM for <quic-issues@ietfa.amsl.com>; Wed, 22 Jan 2020 14:17:05 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A786812085A for <quic-issues@ietf.org>; Wed, 22 Jan 2020 14:17:05 -0800 (PST)
Date: Wed, 22 Jan 2020 14:17:04 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579731424; bh=ep4QfGZrIGmvV8a5BaDFcc7vGE0scX60Iigk2sBf020=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yEfWZ6lZExyZyqgeAy6oXazG8lvW6i7JNtx9cQV1kd4gDmYh8YOKjNbgthFh2fk4g 4f16ZZJBAi2cMVzrCyqs6QwEGussAVVX2rZ4vNwfqieDsJ/Iu14zW0JgqLkPtToQUE G1wfdl+YqC2/I3su7ZTv+fS8dkgePNBD9ZbbHHs8=
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3Y5GHVNLGU2BA34O54GX6GBEVBNHHCCABNRQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3383/review/346942712@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3383@github.com>
References: <quicwg/base-drafts/pull/3383@github.com>
Subject: Re: [quicwg/base-drafts] editorial: This sentence was hard to parse for me (recovery) (#3383)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e28c9e0a2359_4c13fd8988cd95c25849"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/592D3nj1KcJ2lf4pDuv0XEDFQvY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jan 2020 22:17:13 -0000

mirjak commented on this pull request.



> @@ -272,9 +272,10 @@ SHOULD NOT be used to update RTT estimates if it does not newly acknowledge the
 largest acknowledged packet.
 
 An RTT sample MUST NOT be generated on receiving an ACK frame that does not
-newly acknowledge at least one ack-eliciting packet.  A peer does not send an
-ACK frame on receiving only non-ack-eliciting packets, so an ACK frame that is
-subsequently sent can include an arbitrarily large Ack Delay field.  Ignoring
+newly acknowledge at least one ack-eliciting packet.  A peer does usally not
+send an ACK frame when only non-ack-eliciting packets are received. Therefore
+an ACK frame that contains only acknowledge for non-ack-eliciting packets is

thanks. done!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3383#discussion_r369834923