Date: Wed, 22 Jan 2020 14:17:04 -0800
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK3Y5GHVNLGU2BA34O54GX6GBEVBNHHCCABNRQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3383/review/346942712@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3383@github.com>
References: <quicwg/base-drafts/pull/3383@github.com>
Subject: Re: [quicwg/base-drafts] editorial: This sentence was hard to parse
 for me (recovery) (#3383)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e28c9e0a2359_4c13fd8988cd95c25849";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/592D3nj1KcJ2lf4pDuv0XEDFQvY>


----==_mimepart_5e28c9e0a2359_4c13fd8988cd95c25849
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

mirjak commented on this pull request.



> @@ -272,9 +272,10 @@ SHOULD NOT be used to update RTT estimates if it does not newly acknowledge the
 largest acknowledged packet.
 
 An RTT sample MUST NOT be generated on receiving an ACK frame that does not
-newly acknowledge at least one ack-eliciting packet.  A peer does not send an
-ACK frame on receiving only non-ack-eliciting packets, so an ACK frame that is
-subsequently sent can include an arbitrarily large Ack Delay field.  Ignoring
+newly acknowledge at least one ack-eliciting packet.  A peer does usally not
+send an ACK frame when only non-ack-eliciting packets are received. Therefore
+an ACK frame that contains only acknowledge for non-ack-eliciting packets is

thanks. done!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3383#discussion_r369834923
----==_mimepart_5e28c9e0a2359_4c13fd8988cd95c25849
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@mirjak</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3383#discussion_r369834923">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -272,9 +272,10 @@ SHOULD NOT be used to update RTT estimates if it does not newly acknowledge the
 largest acknowledged packet.
 
 An RTT sample MUST NOT be generated on receiving an ACK frame that does not
-newly acknowledge at least one ack-eliciting packet.  A peer does not send an
-ACK frame on receiving only non-ack-eliciting packets, so an ACK frame that is
-subsequently sent can include an arbitrarily large Ack Delay field.  Ignoring
+newly acknowledge at least one ack-eliciting packet.  A peer does usally not
+send an ACK frame when only non-ack-eliciting packets are received. Therefore
+an ACK frame that contains only acknowledge for non-ack-eliciting packets is
</pre>
<p>thanks. done!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3383?email_source=notifications&amp;email_token=AFTOJK2VKBDW5XZ46GRFC4DQ7DAWBA5CNFSM4KKI3SV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSW6Z6A#discussion_r369834923">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJKZZSNWEYPHLVGBSWHDQ7DAWBANCNFSM4KKI3SVQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKZVOQ3XHSBGXH4WMEDQ7DAWBA5CNFSM4KKI3SV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSW6Z6A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3383?email_source=notifications\u0026email_token=AFTOJK2VKBDW5XZ46GRFC4DQ7DAWBA5CNFSM4KKI3SV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSW6Z6A#discussion_r369834923",
"url": "https://github.com/quicwg/base-drafts/pull/3383?email_source=notifications\u0026email_token=AFTOJK2VKBDW5XZ46GRFC4DQ7DAWBA5CNFSM4KKI3SV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSW6Z6A#discussion_r369834923",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5e28c9e0a2359_4c13fd8988cd95c25849--