IETF Logo Mail Archive

Re: [quicwg/base-drafts] Version field <-> Version is not invariant (#3785)

Nick Harper <notifications@github.com> Mon, 06 July 2020 17:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ECBE83A0542 for <quic-issues@ietfa.amsl.com>; Mon, 6 Jul 2020 10:51:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GL-ncq20_jD7 for <quic-issues@ietfa.amsl.com>; Mon, 6 Jul 2020 10:51:04 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A55E03A052C for <quic-issues@ietf.org>; Mon, 6 Jul 2020 10:51:04 -0700 (PDT)
Received: from github-lowworker-ca235ff.ash1-iad.github.net (github-lowworker-ca235ff.ash1-iad.github.net [10.56.110.15]) by smtp.github.com (Postfix) with ESMTP id A3902A0070 for <quic-issues@ietf.org>; Mon, 6 Jul 2020 10:51:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594057863; bh=/QeMRi9SVm+TO9QSAUtWHE/xWQQVnvxZxLK9xa2F/ew=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wdJvFV44Wj17NygvMPiZdSGFac8bmGODZQ+s6xo4AaVEF+QhgRG4RBt8aYrdXXXw3 Hc1B1lvkFUDCSY9Ry66YSe0CQjMGyRttUHFsl28vElC/und+nvixLZFM2TGLT1A/HO DlWpGgbawWSSR32vSKzsybB0zRedIFW3xGrhO2ko=
Date: Mon, 06 Jul 2020 10:51:03 -0700
From: Nick Harper <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2NFKOQHD4D57KQUUV5B5CYPEVBNHHCMZ3PEU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3785/review/443289386@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3785@github.com>
References: <quicwg/base-drafts/pull/3785@github.com>
Subject: Re: [quicwg/base-drafts] Version field <-> Version is not invariant (#3785)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f03648794b78_38043fd22d2cd960826da"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nharper
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5EemkbcwbrKAsMm1BeL0wkd4_dM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jul 2020 17:51:06 -0000

@nharper commented on this pull request.



> @@ -252,8 +252,9 @@ Packets for the same QUIC connection might use different connection ID values.
 
 ## Version
 
-QUIC versions are identified with a 32-bit integer, encoded in network byte
-order.  Version 0 is reserved for version negotiation (see
+The Version field contains a 32-bit integer, encoded in network byte order.
+This value can be used by endpoints to identify a QUIC Version.  A Version field

That wiggle room around "can" sounds good to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3785#discussion_r450385435

v2.39.1 | Report a Bug | By Email | System Status