[quicwg/base-drafts] bc19b6: WIP: Reorganize QPACK
Alan Frindell <afrind@fb.com> Tue, 30 October 2018 00:24 UTC
Return-Path: <bounce+565321.40f-quic-issues=ietf.org@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E25213106D for <quic-issues@ietfa.amsl.com>; Mon, 29 Oct 2018 17:24:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.122
X-Spam-Level:
X-Spam-Status: No, score=-2.122 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LdhUwuqt17uH for <quic-issues@ietfa.amsl.com>; Mon, 29 Oct 2018 17:24:38 -0700 (PDT)
Received: from m71-131.mailgun.net (m71-131.mailgun.net [166.78.71.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4436A13106A for <quic-issues@ietf.org>; Mon, 29 Oct 2018 17:24:38 -0700 (PDT)
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=github.com; q=dns/txt; s=mailo; t=1540859077; h=Content-Transfer-Encoding: Content-Type: Mime-Version: Subject: Message-ID: To: Reply-To: From: Date: Sender; bh=Ugpc9a1j7OBN9Wc0y3HjS5NoiXwsBCzgI1TJfziGliY=; b=RLXzrSCcTCMX7X/iVh+slEWlna+Zc1M2zD3wX5Fvn2cB9vtCjGR1dXE44mxzA/VMd4Gb5xUS C56mFFO+DA0D0ExgjewWtMlh4Df8j9Rd8vjezk/KWXnd8HZbHdtMQAufzf6x99HVGv8FsT4s QWcW2W13eKwbnJDcR+Jm+aNlkSw=
X-Mailgun-Sending-Ip: 166.78.71.131
X-Mailgun-Sid: WyJhNzYyYiIsICJxdWljLWlzc3Vlc0BpZXRmLm9yZyIsICI0MGYiXQ==
Sender: afrind=fb.com@github.com
Received: from github.com (Unknown [192.30.252.34]) by mxa.mailgun.org with ESMTP id 5bd7a4c5.7f34d0126ab0-smtp-out-n02; Tue, 30 Oct 2018 00:24:37 -0000 (UTC)
Date: Mon, 29 Oct 2018 17:24:37 -0700
From: Alan Frindell <afrind@fb.com>
Reply-To: Alan Frindell <afrind@fb.com>
To: quic-issues@ietf.org
Message-ID: <5bd7a4c578172_62662b1e3c8a25847114@hookshot-fe-7191cb1.cp1-iad.github.net.mail>
Subject: [quicwg/base-drafts] bc19b6: WIP: Reorganize QPACK
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="--==_mimepart_5bd7a4c577da3_62662b1e3c8a2584710b5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5IwyN-d6uvyFU7BsuKxoZeXW1pw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2018 00:24:40 -0000
Branch: refs/heads/reorg-qpack Home: https://github.com/quicwg/base-drafts Commit: bc19b645446fc039c25e23a8c515d233f928f372 https://github.com/quicwg/base-drafts/commit/bc19b645446fc039c25e23a8c515d233f928f372 Author: Alan Frindell <afrind@fb.com> Date: 2018-10-29 (Mon, 29 Oct 2018) Changed paths: M draft-ietf-quic-qpack.md Log Message: ----------- WIP: Reorganize QPACK Added a "Compression Process Overview" section near the top, with a high level description of how to compress/decompress. This section now encompasses a lot of what used to be "Encoding Strategies". In the places where I added new text, I temporarily added HTML comments to indicicate so it can get a bit more detailed review. I also deleted a few sentences/paragraphs/sections that I found to be redundant: - Preventing Eviction Races - "An encoder also respects..." - "For header blocks encoded in..." - Single Pass Encoding - "All table updates occur on..." Commit: 6ff9fda2a2e74b5a29fe26a81b57579e07f54283 https://github.com/quicwg/base-drafts/commit/6ff9fda2a2e74b5a29fe26a81b57579e07f54283 Author: Alan Frindell <afrind@fb.com> Date: 2018-10-29 (Mon, 29 Oct 2018) Changed paths: M draft-ietf-quic-qpack.md Log Message: ----------- Address most editorial comments Not addressed: 1. I left the drawing with 'Draining Entries' without a specific definition in the text. I think it can be interpreted OK, and 'Unreferencable' isn't actually true. 2. With respect to leaving blocked data in flow control, I changed should to SHOULD instead of can. My understanding is that you don't have to do a SHOULD, if you have a good reason? It's important enough that we want to convey more than ability. 3. I skipped redoing the indexing diagram for its own commit 4. I haven't moved the TSS guidance out of the TSS instruction section yet. I can't lift the whole paragraph without refactoring some of the other text. 5. I think peer's encoder/decoder is correctly possessive. Doesn't the coder belong to the peer? 6. I removed all the instances of 'A decoder', but there are still a bunch of references to 'An encoder'. I'm not sure if the consistency is an improvement in readability yet, so delaying changing more pending feedback. Compare: https://github.com/quicwg/base-drafts/compare/9e565628e065...6ff9fda2a2e7 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
- [quicwg/base-drafts] bc19b6: WIP: Reorganize QPACK Alan Frindell